mORMot Open Source

DDGG

Member

Registered: 2018-01-10

Posts: 18

SynCommon comment issue

I found some document issue in SynCommons.pas start from the line 14309:

/// same as VarIsEmpty(V) or VarIsEmpty(V), but faster
// - we also discovered some issues with FPC's Variants unit, so this function
// may be used even in end-user cross-compiler code
function VarIsEmptyOrNull(const V: Variant): Boolean;
  {$ifdef HASINLINE}inline;{$endif}

/// same as VarIsEmpty(PVariant(V)^) or VarIsEmpty(PVariant(V)^), but faster
// - we also discovered some issues with FPC's Variants unit, so this function
// may be used even in end-user cross-compiler code
function VarDataIsEmptyOrNull(VarData: pointer): Boolean;
  {$ifdef HASINLINE}inline;{$endif}

Best regards.

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,244

Website

Re: SynCommon comment issue

Please use a pull request on github - it is much easier to merge such issues.
If you don't know how it works, it is not difficult by following the available tutorials, and a good first step into real Open Source contribution!

Thanks for the input!