You are not logged in.
- Topics: Active | Unanswered
#1 2019-08-03 08:49:37
- edwinsn
- Member
- Registered: 2010-07-02
- Posts: 1,215
A PR for a fix for handling boolean values of the JSON standand
@ab, since my previous PR didn't get you noticed until a few days later, so I'm not sure if you really monitors the github PR notification, and to avoid my local repository to fall behind your repository, I'm notifying you this pull request, and if it makes sense, I wish you can merge it ASAP.
The PR fixed: `TDocVariantData.B` or `GetBooleanByName` couldn't correctly handle the "true" and "false" JSON values.
Just in case anyone of you find my contribution workflow is not optimized:
- I have two local repository:
- 'mORMotOfficial': which is exactly the official mORMot repository.
- 'mORMotFork': For pushing to my github repository.
- When I need to make a change I work in the 'mORMotOfficial' folder, once passed tests I sync it to the sibling 'mORMotFork' folder, which will then be pushed to my github fork of the mORMot repository. Then I create pull request to @ab.
So if the official mORMot repo has new commits, I'll have to:
- sync my fork on github
- pull my fork to local
- backup my changes to somewhere else and pull the official repo to local
- re-apply my changes to both the local fork and working folders
- push again to github
So that's why I'm afraid of falling behind the official repo after I created a new PR 
Thanks.
Delphi XE4 Pro on Windows 7 64bit.
Lazarus trunk built with fpcupdelux on Windows with cross-compile for Linux 64bit.
Offline
#3 2019-08-03 18:30:04
- edwinsn
- Member
- Registered: 2010-07-02
- Posts: 1,215
Re: A PR for a fix for handling boolean values of the JSON standand
yes, thanks ab!
Delphi XE4 Pro on Windows 7 64bit.
Lazarus trunk built with fpcupdelux on Windows with cross-compile for Linux 64bit.
Offline