mORMot Open Source

@ab:
in mORMot2 survey you also asked how to continue with source code management and there were many answers to also keep fossil as scm (at least in parallel to github). Just for curiosity: do you intend to set up also a fossil repository for mORMot2 in future?
Thanks a lot and have a nice weekend!
Paul

Dear ab,

yesterday you've fixed some [dvoAllowDoubleValue] issues in https://synopse.info/fossil/info/68271abc8213256f.
I've tested this commit but it does not solve my issue above, as in SynSelftests.pas you check JSON Encoding/Decoding of a double value without using [dvoAllowDoubleValue] which results in failing (at least if you use a German number format).
Please fix it, too (I've suggested some code in my posting of 21 Jan in this topic).

Thank you very much!
Paul

IMHO the reason for this issue is the same as for the issue described in https://synopse.info/forum/viewtopic.php?id=3739 and was most probably introduced with {3129} [aa35ac110a].

If the TDocVariantOptions does not include [dvoAllowDoubleValue], then JSON encoding/decoding will return any double value with more than 4 digits behind the decimal separator as a string value instead of a double value.

My idea was to include [dvoAllowDoubleValue] in your line

VDoc.InitJSON(VJSON_In[I],[dvoValueCopiedByReference]);

like

VDoc.InitJSON(VJSON_In[I],[dvoValueCopiedByReference, dvoAllowDoubleValue]);

but unfortunately this does not work as expected. It seems that VDoc.InitJSON does not consider an included [dvoAllowDoubleValue] option in opposite to e.g. VariantLoadJSON.

Unfortunately I didn't succeed to find out how to circumvent this issue when using VDoc.InitJSON as in your example. Perhaps somebody else in the forum may help.

Paul

Dear ab,
Perhaps I have described my finding in a misunderstanding manner, sorry.
I'm with you that you use internally only JSON number representation with '.' as decimal separator.
But in current implementation {3343} the line

P := VariantLoadJSON(Va,P);

doesn't return Va as a double but as a string value (displayed by the IDE debugger as '0.012345') as internally the variable TryCustomVariants of function VariantLoadJSON is set to nil.
Thus

CheckSame(Va,r);

reads as
a) in case of system decimal separator is set to '.': Checksame('0.012345', 0.012345); which succeeds
b) in case of system decimal separator is set to ',': Checksame('0.012345', 0,012345); which fails
as Checksame compares a string with a double value.

After adding the suggested changes in my previous post

P := VariantLoadJSON(Va,P,nil,@VaAllowDblVal);

sets the internal variable TryCustomVariants to [dvoAllowDoubleValue] and therefore this line returns Va as a double value (displayed by the IDE debugger as 0.012345 (in case of system decimal separator is set to '.') and as 0,012345 (in case of system decimal separator is set to ',')
Thus

CheckSame(Va,r);

reads now as
a) in case of system decimal separator is set to '.': Checksame(0.012345, 0.012345); which succeeds
b) in case of system decimal separator is set to ',': Checksame(0,012345, 0,012345); which succeeds, too.
as Checksame now compares a double value with a double value.

Thank you!
Paul

As it seems that my account "Paul" as well as my first post prior to AB's yesterday's answer has obviously been deleted, I just want to re-add my question for completeness:

Using the actual mORMot version TestSQL3.exe fails in EncodeDecodeJSON if system decimal separator is set to "," instead of "."
...
1.2. Low level types:
...
!  - Encode decode JSON: 100 / 283,293 FAILED  4.26s
...
Using mORMot 1.18.3310 ERTL FTS3
Running on Windows 7 64bit SP1 (6.1.7601) with code page 1252
TSQLite3LibraryStatic 3.16.0 with internal MM
Generated with: Delphi 7 compiler

Time elapsed for all tests: 89.32s
Tests performed at 04.01.2017 12:48:02

Total assertions failed for all test suits:  100 / 26,703,849
! Some tests FAILED: please correct the code.

The same is true when using Delphi 10.1 Berlin compiler.

I've tracked down this issue to lines 6151 and 6194 in SysSelfTests.pas:

6151:     r := Random;
...
6194:     CheckSame(Va,r);

In case system decimal separator is set to ",": e.g. r = 0,0123456789 ("," as decimal separator) but Va = '0.0123456789' ("." as decimal separator) => line 6194 fails.
In case system decimal separator is set to ".": e.g. r = 0.0123456789 ("." as decimal separator) and Va = '0.0123456789' ("." as decimal separator) => line 6194 doesn't fail.

As the usual layout in Austria and German is using "," as decimal separator, changing the system decimal separator to "." is not an option. Thus my question was how to circumvent this failure?

Thank you very much!
Paul