mORMot Open Source

Sorry, but I don't see a new version of the mormot.db.sql.odbc unit in the trunk...

I updated to the trunk, but the error still here.

I checked this test example on Lazarus/FPC stable.

Yes, indeed, on this version the second exception does not occurs.
Then we can probably skip this error.

Thank you!

Good morning, Arnaud!

Thanks a lot, this feature works great

And I just installed again libdeflate-dev.

After changing the file name in mORMot to libdeflatepas.a, everything is also compiled without problems.

Great!

I updated mORMot2 to the current trunk, downloaded the latest static libraries, opened the mormot2 package in Lazarus IDE, and tried to compile it.
mormot.core.json unit does not compile with an error:
Wrong number of parameters specified for call to "<Procedure Variable>"

function TSynDictionary.ForEach(const OnMatch: TOnSynDictionary;
  KeyCompare, ValueCompare: TDynArraySortCompare; const aKey, aValue;
  Opaque: pointer): integer;
var
  k, v: PAnsiChar;
  i, n, ks, vs: PtrInt;
begin
  fSafe.Lock;
  try
    result := 0;
    if not Assigned(OnMatch) or
       (not Assigned(KeyCompare) and          <---
        not Assigned(ValueCompare)) then      <---
      exit;

mormot.core.json.pas(9345,32) Error: Wrong number of parameters specified for call to "<Procedure Variable>"
mormot.core.json.pas(9346,34) Error: Wrong number of parameters specified for call to "<Procedure Variable>"

Good afternoon!

My project contains the mormot2 package in the requirements.
In the mormot2' package options, the path to the libraries (_FL) is specified as follow:
../../static/$(TargetCPU)-$(TargetOS)

Yes, you, of course, right - the libdeflate-dev package is not used at runtime.
I did not quite correctly wrote - I installed it when I builded a some application.
I can delete it, but if it needs to be needed again, it will have to be installed again.
In general, a small problem.

I checked it - after removing libdeflate-dev, indeed, mORMot2 compiled successfully.
After re-installing libdeflate-dev, mORMot2 again stopped compiled.
As a result, I deleted libdeflate-dev, as long as it is needed again.

However, it is still not clear why Lazarus/fpc is looking for all such libraries in the system, if the library already found in the directory, specified in the package options.
But since libdeflate-dev is not needed constantly, we can assume that everything is fine, and on most systems this error will not occurs.

Good afternoon,

Today I updated mORMot2 to the latest trunk version and downloaded new static libraries.
After that, when I open in Lazarus a project using mORMot2, and do "Clean up and Build...", two link errors occurrs:

multiple definition of `libdeflate_malloc'
multiple definition of `libdeflate_free'

Verbose: Linking /home/data/projects/TestAppSrv/appsrv.console

Warning: linker: /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libdeflate.a(utils.o): in function `libdeflate_malloc':
Error: (.text+0x30): multiple definition of `libdeflate_malloc'; /home/data/projects/TestAppSrv/dependencies/fpc_components/3rd_party/mORMot2/packages/lazarus/lib/x86_64-linux/mormot.lib.z.o:/home/data/projects/TestAppSrv/dependencies/fpc_components/3rd_party/mORMot2/packages/lazarus//../../src/lib/mormot.lib.z.pas:928: first defined here

Warning: linker: /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libdeflate.a(utils.o): in function `libdeflate_free':
Error: (.text+0x40): multiple definition of `libdeflate_free'; /home/data/projects/TestAppSrv/dependencies/fpc_components/3rd_party/mORMot2/packages/lazarus/lib/x86_64-linux/mormot.lib.z.o:/home/data/projects/TestAppSrv/dependencies/fpc_components/3rd_party/mORMot2/packages/lazarus//../../src/lib/mormot.lib.z.pas:934: first defined here

appsrv.console.lpr(174,1) Error: Error while linking
appsrv.console.lpr(174,1) Verbose: There were 1 errors compiling module, stopping
Verbose: Compilation aborted
Verbose: /opt/fpcupdeluxe/lazarus_trunk/fpc/bin/x86_64-linux/ppcx64 returned an error exitcode

As a result, mORMot2 is not compiled: (

OS: SMP Debian 5.10.19-1 (2021-03-02) x86_64 GNU/Linux
Lazarus/fpc: 2.1.0 / 3.3.1 (trunk)

locate libdeflate.a
/usr/lib/x86_64-linux-gnu/libdeflate.a

Good Morning!

I just wanted to update Lazarus / FPC through FPCUPDeluxe, but got the same error, as I showed early.
Repeated attempt was also completed with the same error:
/lib/zdbc/x86_64-linux/mormot.core.datetime.ppu:mormot.core.datetime.pas(13,101) Fatal: (10022) Can't find unit mormot.core.datetime used by mormot.core.text

fpcupdeluxe: info: LazarusNativeInstaller (GetModule: Lazarus): Lazarus was at revision: 64666
fpcupdeluxe: info: LazarusNativeInstaller (GetModule: Lazarus): Lazarus is now at revision: 64760
fpcupdeluxe: info: Lazarus native builder: Detected source version Lazarus: 2.1.0
fpcupdeluxe: info: Lazarus native builder: Using FPC compiler with version: 3.3.1
fpcupdeluxe: Start of compile error summary.
/lib/zdbc/x86_64-linux/mormot.core.datetime.ppu:mormot.core.datetime.pas(13,101) Fatal: (10022) Can't find unit mormot.core.datetime used by mormot.core.text
(10028) Recompiling mormot.core.datetime, checksum changed for ./lib/zdbc/x86_64-linux/mormot.core.text.ppu
fpcupdeluxe: Start of compile error summary.
Fatal: (1018) Compilation aborted
./lib/zdbc/x86_64-linux/mormot.core.datetime.ppu:mormot.core.datetime.pas(13,101) Fatal: (10022) Can't find unit mormot.core.datetime used by mormot.core.text
fpcupdeluxe: Start of compile error summary.
Error: /opt/fpcupdeluxe/lazarus_trunk/fpc/bin/x86_64-linux/ppcx64 returned an error exitcode
fpcupdeluxe: Start of compile error summary.
Error: (lazarus) Compile package zcomponent 8.0: stopped with exit code 1

I used last trunk versions of the mORMot2 and ZeosLib.

The update was completed successfully only after I temporarily disabled the MORMOT2 define in the ZeosLib.

After the update Lazarus/FPC, I enabled the MORMOT2 define again, and tried to compile sequentially ZeosLib and mORMot2.

The zcomponent package compiled successfully, but when compiling the mormot2 package there was a strange error:
mormot.soa.core.pas(1302,40) Error: Compilation raised exception internally
Error: An unhandled exception occurred at $000000000076E5B8:
Error: EAccessViolation: Access violation

...
mormot.rest.core.pas(3352,63) Hint: Variable "ContentType" of a managed type does not seem to be initialized
mormot.rest.core.pas(3363,13) Note: Call to subroutine "function IdemPChar(p:PUtf8Char;up:PChar):Boolean;" marked as inline is not inlined
mormot.rest.core.pas(3376,13) Note: Call to subroutine "function IdemPChar(p:PUtf8Char;up:PChar):Boolean;" marked as inline is not inlined
mormot.rest.core.pas(3988,26) Hint: Local variable "newOffset" of a managed type does not seem to be initialized
mormot.rest.core.pas(47,3) Hint: Unit "mormot.core.search" not used in mormot.rest.core
Verbose: Compiling /home/data/projects/TaskMachine/dependencies/fpc_components/3rd_party/mORMot2/src/soa/mormot.soa.core.pas
mormot.soa.core.pas(1302,40) Error: Compilation raised exception internally
Error: An unhandled exception occurred at $000000000076E5B8:
Error: EAccessViolation: Access violation
Verbose: Compilation aborted
Debug:   $000000000076E5B8
Debug: 
Verbose: /opt/fpcupdeluxe/lazarus_trunk/fpc/bin/x86_64-linux/ppcx64 returned an error exitcode

After the second try to compile the mormot2 package, another error occurred:
mormot.soa.core.pas(1302,39) Error: Incompatible type for arg no. 1: Got "TServiceContainer", expected "Options"

Verbose: Compiling mormot2.pas
Verbose: Compiling /home/data/projects/TaskMachine/dependencies/fpc_components/3rd_party/mORMot2/src/soa/mormot.soa.core.pas
mormot.soa.core.pas(1302,39) Error: Incompatible type for arg no. 1: Got "TServiceContainer", expected "Options"
mormot.rest.core.pas(1994,17) Hint: Found declaration: ServicesRelease(Options);
mormot.soa.core.pas(1394,20) Hint: Variable "bits" does not seem to be initialized
mormot.soa.core.pas(1404,44) Hint: Local variable "method" of a managed type does not seem to be initialized
mormot.soa.core.pas(1510,21) Hint: Variable "Services" of a managed type does not seem to be initialized
mormot.soa.core.pas(1522,18) Hint: Variable "Names" of a managed type does not seem to be initialized
mormot.soa.core.pas(1537,47) Hint: Local variable "temp" does not seem to be initialized
mormot.soa.core.pas(1782,25) Hint: Local variable "nfo" of a managed type does not seem to be initialized
mormot.soa.core.pas(1834,0) Verbose: There were 1 errors compiling module, stopping
Verbose: Compilation aborted
Verbose: /opt/fpcupdeluxe/lazarus_trunk/fpc/bin/x86_64-linux/ppcx64 returned an error exitcode

It looks like this issue is not related to the problem under discussion, but it is occurred when recompiling the mormot2 package.

Full "Clean Up and Build" in the Lazarus with an open project using Mormot2 leads to the same error as before (Can't find unit mormot.core.datetime used by mormot.core.text).
With a new empty project "Clean Up and Build" is successful.

It's all so inconveniencly...

Arnaud, may be you will have time to look at the possibility of removing dependency between mormot.core.datetime and mormot.core.text?

It’s strange. In the file .../fpcsrc/rtl/inc/systemh.inc
there are lines:

{ Using inlining for small system functions/wrappers }
{$inline on}
{$define SYSTEMINLINE}

But at the same time, opening the file .../zeoslib/src/ZeosLazarus.inc

{$IFDEF SYSTEMINLINE} //global FPC define
  {$DEFINE WITH_INLINE}           // compiler supports inline methodes
{$ENDIF}

I see the line {$DEFINE WITH_INLINE} in a pale color, i.e. as if SYSTEMINLINE is not defined.

I'll see this in more details later.

Arnaud, yesterday I wrote that after the last commit in git, my test rest service stopped working.
It started returning error 400 - bad request.
After replacing the mormot.rest.core.pas file with its previous version, the error gone.

As I can see, the sequence of calling destructors has changed:

old:

FreeAndNil(fRun);
FreeAndNil(fServices);
for cmd := Low(cmd) to high(cmd) do
  FreeAndNil(fAcquireExecution[cmd]); // calls fOrmInstance.OnEndThread

new:

for cmd := Low(cmd) to high(cmd) do
  FreeAndNil(fAcquireExecution[cmd]); // calls fOrmInstance.OnEndThread
FreeAndNil(fServices);
FreeAndNil(fRun); // after fAcquireExecution+fServices

With the new sequence of destructors, the method (GetUsr) declared in the interface is not called:

  IUsrService = interface(IInvokable)
    ['{64CDE670-5D34-4050-B0E6-36A21F0C21CE}']
    function GetUsr(const ID: RawUTF8; out Usr: TUsrDto): TCQRSResult;
  end;

Yes, after I forcibly enabled the WITH_INLINE define, Zeos compiled successfully,
only about 30 warnings were issued that the functions was not inline:

mormot.core.datetime.pas(1027,13) Note: Call to subroutine "function Iso8601ToDateTimePUtf8Char(P:PUtf8Char;L:LongInt=`0`):Double;" marked as inline is not inlined
mormot.core.datetime.pas(1294,9) Note: Call to subroutine "function VariantToUtf8(const V:Variant;var Text:UTF8String):Boolean;" marked as inline is not inlined
mormot.core.datetime.pas(1323,7) Note: Call to subroutine "procedure TSynSystemTime.Clear;" marked as inline is not inlined
mormot.core.datetime.pas(1693,5) Note: Call to subroutine "function UInt2DigitsToShortFast(Value:Byte):ShortString[4];" marked as inline is not inlined
mormot.core.datetime.pas(1694,5) Note: Call to subroutine "function UInt4DigitsToShort(Value:LongWord):ShortString[4];" marked as inline is not inlined
mormot.core.datetime.pas(1875,33) Note: Call to subroutine "function UInt3DigitsToShort(Value:LongWord):ShortString[4];" marked as inline is not inlined

This is clear. But as I wrote, I tried to enable only the MORMOT2 define, and Zeos couldn't compile.
Therefore, just to test compilation, I have included USE_SYNCOMMONS as well.
The errors still remained, I showed them in the previous message.

Now, after updating the Zeos to the current trunk, if I enable the MORMOT2 define, other compilation errors occur, e.g.:

unit ZDbcPostgreSqlResultSet:

then JSONWriter.AddJSONEscape(P, ZDbcUtils.GetAbsorbedTrailingSpacesLen(P, {$IFDEF MORMOT2}mormot.core.base{$ELSE}SynCommons{$ENDIF}.StrLen(P)))
ZDbcPostgreSqlResultSet.pas(798,134) Error: Identifier not found "base"
ZDbcPostgreSqlResultSet.pas(909,134) Error: Identifier not found "base"

then {$IFDEF WITH_COLUMNS_TO_JSON}{$IFDEF MORMOT2}mormot.core.text{$ELSE}SynCommons{$ENDIF}.{$ENDIF}HexToBin(Buffer+2, @Result.D1, SizeOf(TGUID))
ZDbcPostgreSqlResultSet.pas(1949,71) Error: Identifier not found "text"


const PGOidLopOpenMode: Array[TZLobStreamMode] of Integer = (INV_READ or INV_WRITE, INV_WRITE, INV_READ or INV_WRITE);
ZDbcPostgreSqlResultSet.pas(2870,83) Error: Illegal expression
ZDbcPostgreSqlResultSet.pas(2870,117) Error: Illegal expression

Maybe this is due to the units names with dots in functions calls under fpc?
Although on an fpc trunk this should work...

then JSONWriter.AddJSONEscape(P, ZDbcUtils.GetAbsorbedTrailingSpacesLen(P, SynCommons.StrLen(P))) ==> was changed to:
then JSONWriter.AddJSONEscape(P, ZDbcUtils.GetAbsorbedTrailingSpacesLen(P, {$IFDEF MORMOT2}mormot.core.base{$ELSE}SynCommons{$ENDIF}.StrLen(P)))

then {$IFDEF USE_SYNCOMMONS}SynCommons.{$ENDIF}HexToBin(Buffer+2, @Result.D1, SizeOf(TGUID)) ==> was changed to:
then {$IFDEF WITH_COLUMNS_TO_JSON}{$IFDEF MORMOT2}mormot.core.text{$ELSE}SynCommons{$ENDIF}.{$ENDIF}HexToBin(Buffer+2, @Result.D1, SizeOf(TGUID))

Perhaps the same could be in other units affected.

Also the unit mormot.db.sql.zeos uses unit ZURL, but it is missing in the package ZComponent, so I added it manually.

It is difficult to tell right away which of the two libraries the issue is in.

On the one hand, an exception occurs in ZeosLib, but on the other hand, an invalid column index = 1 is passed to the TZAbstractResultSetMetadata.GetColumnLabel () function from the TSqlDBZEOSStatement.ExecutePrepared() function of the mormot.db.sql.zeos unit.

The query 'select current_timestamp from rdb$database' returns one column whose index in the TStringList must be 0.
This query initiated by mORMot, not Zeos:

mormot.db.sql:  line 6562 - TSqlDBConnection.Connect()
                line 6572 - fServerTimestampAtConnection := ServerDateTime;

                line 6658 - TSqlDBConnection.GetServerDateTime: TDateTime;
                line 6667 - with Execute(fSqlGetServerTimestamp, []) do

                line 3098 - fSqlGetServerTimestamp := DB_SERVERTIME[db];
                line  400 - DB_SERVERTIME: array[TSqlDBDefinition] of RawUtf8 = (
                            ..., 'select current_timestamp from rdb$database', ...);

As we can see, TSqlDBZEOSStatement.ExecutePrepared() calls fResultInfo.GetColumnLabel() with parameter = 1:
                                   ...
mormot.db.sql.zeos:    line 1144 - fResultInfo := fResultSet.GetMetadata;
                                   n := fResultInfo.GetColumnCount;
                                   fColumn.Capacity := n;
                                   for i := 0 to n - 1 do
                                     begin
                       line 1149 -     name := fResultInfo.GetColumnLabel(i + FirstDbcIndex);
                                                                          ^^^^^^^^^^^^^^^^^
                                       HERE i = 0, FirstDbcIndex = 1,
                                       THEREAFTER IN TZAbstractResultSetMetadata.GetColumnLabel()
                                       PASSED VALUE = 1
                                       ...
                                     end;

ZDbcResultSetMetadata: line  641 - TZAbstractResultSetMetadata.GetColumnLabel(ColumnIndex: Integer): string;
                       line  692 -   if FColumnsLabelsCS = nil then
                                       FillListAndMakeUnique;
         EXCEPTION ==> line  694 -   Result := ColumnsLabels[ColumnIndex{$IFNDEF GENERIC_INDEX} - 1{$ENDIF}];
                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                       $GENERIC_INDEX IS DEFINED,
                                       THEREFORE IN FACT WE ARE TRYING TO GET A TStringList ITEM WITH INDEX = 1,
                                       THEREFORE THERE IS AN EXCEPTION List index (1) out of bounds
                                                                                     
Project Test Application Server raised exception class 'EStringListError' with message:
List index (1) out of bounds
In file '../../src/dbc/ZDbcResultSetMetadata.pas' at line 694:
Result := ColumnsLabels[ColumnIndex{$IFNDEF GENERIC_INDEX} - 1{$ENDIF}];

I made another, a very simple fpc example (console app) to reproduce this error.
The database can either be created with my script, or simply you can specify the path to another Firebird 4 database and correct the query in the project.

After starting the application from the IDE, the 'List index (1) out of bounds' exception will occur and you can see everything in the debugger.

Below is a link to the test example:
https://drive.google.com/file/d/1myazV8 … sp=sharing

Thank you!