mORMot Open Source

Hello everyone,

Today, during the mORMot2 migration process, I encountered an issue related to JSON serialization and deserialization. I observed a different behavior in mORMot2 compared to mORMot1. To replicate the problem, please note that custom reader and writer procedures are registered for a class, TBase. In mORMot1, all descendants of TBase (TChild = class(TBase)) were serialized and deserialized using these reader and writer procedure. However, this is no longer the case in mORMot2. I now need to register the same reader and writer methods for each descendant.

TJSONSerializer.RegisterClassForJSON(TBase);
TJSONSerializer.RegisterClassForJSON(TChild );


TRttiJson.RegisterCustomSerializerClass(TBase,
    TBaseClassJSON.Reader, TBaseClassJSON.Writer);

//in mormot2 this is necessary
TRttiJson.RegisterCustomSerializerClass(TChild ,
    TBaseClassJSON.Reader, TBaseClassJSON.Writer);

Is this an unintended issue or an intentional change in mORMot2? It would be beneficial if the behavior in mORMot2 aligns with that of mORMot1, as otherwise, I would need to register the same reader and writer methods separately for all my descendants.

Thanks in Advance

Hello everyone,

I've encountered the following issue after migrating from Mormot1 to Mormot2 and unfortunately haven't found a solution yet. When using the objectToJson function with the parameters woHumanReadable or woEnumSetsAsText, the generated JSON can no longer be validly created into an object using the jsonToObject function. The set of enum values is empty in the resulting object, and the enum contains the first value. However, if you don't use woEnumSetsAsText or woHumanReadable, so that sets and enums are included in the JSON as ordinal values, creating the object from the JSON string works as expected. I can provide an example for you to reproduce the issue. Here's a brief example code. Unfortunately, this aspect is currently preventing the upgrade to Mormot 2.1 stable.

I hope you can assist me with this issue. It's possible that I may have forgotten a necessary register call in Mormot2 now.

Type
  TSimpleEnum = (enTest, enTest2);
  TEnumSet = set of TSimpleEnum;

  TSimpleExample = class(TPersistent)
  private
    FFullName: string;
    FEnumSet: TEnumSet;
    FEnum: TSimpleEnum;
    procedure SetEnumSet(const Value: TEnumSet);
    procedure SetFullName(const Value: string);
    procedure SetEnum(const Value: TSimpleEnum);
  published
    property FullName: string read FFullName write SetFullName;
    property EnumSet : TEnumSet read FEnumSet write SetEnumSet;
    property Enum: TSimpleEnum read FEnum write SetEnum;
  end;

procedure testit;
begin
  TJSONSerializer.RegisterClassForJSON([TSimpleExample]);

  var oExample := TSimpleExample.Create;
  oExample.FullName := 'ABC';
  oExample.EnumSet := [enTest2];
  oExample.Enum := enTest;

  var sJSON := OBjecttoJSON(oExample,[woHumanReadable]);

  oExample.Free;
  oExample := TSimpleExample.Create;
  var bValid: boolean;

  JsonToObject(oExample,Pointer(StringToUtf8(sJSON)),bValid,nil);
  //bValid = false
  //oExample.EnumSet is Empty
end;

Thanks in advance
  Sebastian