mORMot Open Source

@Javierus , Thank you very much for all that number of examples, in addition to all the SAD documentation that you have provided.

I'm using FPC 3.2.3 (fixes) with Windows 11 and wanted to learn about HTTP Basic Authentication.
So I took the "08-basicauth" example, but I ran into the following issues:

1. It was showing a related error that "RegisterInterfaces" was missing...
   I fixed it by adding the following code to the "api.interfaces.pas" file:

   initialization
     TInterfaceFactory.RegisterInterfaces([TypeInfo(IBasicAuthApi)]);

2. Inside the Log file, an error related to "useHttpApiRegisteringURI" is displayed.
   "TRestHttpServer(06222840) Create: HttpSetServiceConfiguration() failed: ERROR_ACCESS_DENIED (5) for root - useHttpApiRegisteringURI may need admin rights"
   "EXC   ERestHttpServer {Message:"TRestHttpServer: http.sys URI registration error ERROR_ACCESS_DENIED for http://+:8080/root (you need to register the URI - try to use useHttpApiRegisteringURI)"}"
   I solved it by changing from "HTTP_DEFAULT_MODE" to "useHttpAsync"

     // Create HTTP server
     fHttpServer := TRestHttpServer.Create(aPort, [fRestServer],
       '+', useHttpAsync, {threaded=}32); 

3. It showed several memory leaks when exiting the program.
   I solved it by adding a variable "fModel: TOrmModel;" and you don't need to free "fBasicAuthApi"

     // Create in-memory REST server (no database needed)
     fModel := TOrmModel.Create([]);
     fRestServer := TRestServerFullMemory.Create(
       fModel, 'root', {authentication=}true); 
   
   destructor TBasicAuthServer.Destroy;
   begin
     Stop;
     fHttpServer.Free;
     //fBasicAuthApi.Free;
     fModel.Free;
     fRestServer.Free;
     inherited Destroy;
   end;

4. The program did not work correctly, with or without authentication it did not show the expected results. 
   After spending hours understanding how it worked, I found that the problem is with "methodName"

   For some reason "Ctxt.UriMethodPath" always returns empty.
   And within the code you have to:

     methodName := Ctxt.UriMethodPath;
     if methodName = '' then
     begin
       // Fallback to full URI
       methodName := Ctxt.Call^.Url;
     end;

   The problem is that it returns the entire Url.
   For example, we obtain that:
   methodName ="root/BasicAuthApi.PublicSection" , but it was expected that methodName ="PublicSection"
   methodName ="root/BasicAuthApi.OnlyRole2" , but it was expected that methodName ="OnlyRole2"
   methodName ="root/BasicAuthApi.OnlyRole1Json?par1=hello" , but it was expected that methodName ="OnlyRole1Json"

   I solved it by doing the following code (maybe not the best solution, but it works)

     methodName := Ctxt.UriMethodPath;
     if methodName = '' then
     begin
       tmpUrl := Ctxt.Call^.Url;
       mPosIni := PosI('.',tmpUrl) + 1;
       mPosEnd := PosI('?',tmpUrl);
       if mPosEnd >0 then
         mLen :=  mPosEnd - mPosIni
       else
         mLen := length(tmpUrl);
       methodName := Copy(tmpUrl,mPosIni,mLen);
     end;

Currently, the "DynArrayLoadCsv" function only allows csv file content to have a delimiter/separator ','.

IMHO, the function should have the option (not mandatory) to specify the delimiter/separator.

Respectfully, I propose changing the definition to: (It does not affect programs that have already been created.)

function TDynArrayLoadCsv(var Value: TDynArray; Csv: PUtf8Char;
  Intern: TRawUtf8Interning = nil; CommaSep: AnsiChar=','): boolean;

function DynArrayLoadCsv(var Value; const Csv: RawUtf8; TypeInfo: PRttiInfo;
  Intern: TRawUtf8Interning = nil; CommaSep: AnsiChar=','): boolean;

And its respective implementation code: (I've only changed the constant ',' to a variable "CommaSep: AnsiChar")

An example of using a CSV file containing the semicolon ';' delimiter/separator:

if DynArrayLoadCsv(csvItems, csvContent, TypeInfo(TCsvItems), nil, ';') then
begin
  
end;

IMHO, I agree with you.

Thanks.