mORMot Open Source

Another problem regard to TSQLTableToDataSet, since the return JSON schema
{"fieldCount":4,"values":["ID","Time","Name","Question"],"rowCount":0} has no column length type and length info,
so when no record return, the create dataset's string field length is alway 1, this make edit dataset impossible, also there has a latency problem, even if there has record return, the fieldlength is get the max length of the return record add one, suppose we have a string field length is 50, but current return record's max length is 20, then we will not able to input length big than 20, If this is the reason forced me to leave mORMot, it will be very sad.

about External DB not return column info, after debug, when use sqlite, in TSQLRequest.Execute
after  step, there has

function TSQLRequest.Execute(aDB: TSQLite3DB; const aSQL: RawUTF8; JSON: TStream;
  Expand: boolean=false): PtrInt;
...
    if (result=0) and W.Expand then begin    //  ****** deal with RowCount = 0
      // we want the field names at least, even with no data: we allow RowCount=0 
      W.Expand := false; //  {"FieldCount":2,"Values":["col1","col2"]}
      W.CancelAll;
      for i := 0 to FieldCount-1 do
        W.ColNames[i] := sqlite3.column_name(Request,i);
      W.AddColumns;
    end;
    W.EndJSONObject(0,result);

when use External DB, in TSQLDBStatement.FetchAllToJSON
after step, there is no code deal with RowCount=0,

function TSQLDBStatement.FetchAllToJSON(JSON: TStream; Expanded: boolean;
  DoNotFletchBlobs: Boolean=false): PtrInt;
...
    // write rows data
    while Step do begin
      ColumnsToJSON(W,DoNotFletchBlobs);
      W.Add(',');
      inc(result);
    end;
    //  ****** there is no code deal with RowCount = 0
    W.EndJSONObject(0,result);

so when rowcount=0, the column info is not write.

After my post, I see your post, this is not important, only I learn found,  but this two method,

SQLTable := Database.MultiFieldValues(TSQLSampleRecord, '', '1=2'); //or
SQLTable := Database.MultiFieldValues(TSQLSampleRecord, '', 'ID=?', [0]);

i want return a valid JSON result to create a valid dataset:

fDataSet := TSQLTableToDataSet(Self, SQLTable, Database);

for sqlite3 db, no problem, but for external DB, the two method all failed,
the first method return a nil SQLTable, the second return a SQLTable has no column info.

thanks!

Client If change :

  SQLTable := Database.MultiFieldValues(TSQLSampleRecord, '', '1=2'); to 
  SQLTable := Database.MultiFieldValues(TSQLSampleRecord, '', 'ID=?', [0]);

if Use TSQLRestServerDB then also ok, but after change server to External DB

  VirtualTableExternalRegisterAll(Model, MSSQLConnectionProperties);

then Client return SQLTable has no column info, then TSQLTableToDataSet will
generate such exception:

---------------------------
Debugger Exception Notification
---------------------------
Project Project04Client.exe raised exception class EDatabaseError with message 'No fields defined.  Cannot create dataset'.
---------------------------
Break   Continue   Help   
---------------------------

Another problem, if first test use sqlite db, after some test, then change to External DB,
seems should manual delete the *.db3 file, from External DB to sqlite db, also need manual
delete the *.db3 file, else will generate such

---------------------------
Debugger Exception Notification
---------------------------
Project Project04Server.exe raised exception class ESQLite3Exception with message 'no such module: External'.
---------------------------
Break   Continue   Help   
---------------------------

I has upload a picture at http://pan.baidu.com/s/1h6yly, you can see the picture.

TestSQL3.exe and TestSQL3.map is in the same folder.

Yes, the last version, just download from source control.

>>I believe there are more important tasks to be considered.

Yes, I also feeling this, these days I learn mORMot,
for I the lack a bridge between Old UI DB Bind Designer is a issue, and auto master-detail applyupdate,
I want the bidirectional edit of clientdataset, I think if this
feature implement, will able to attract a number of the original developers,
just my personal view, sorry for my poor english.

<<About ValVariant missing field, it is strange, since I'm not able to reproduce it.
Are you sure you retrieved the latest version from http://synopse.info/fossil - see http://synopse.info/fossil/wiki?name=Get+the+source ?>>

Yes, I get the latest version, from 2013-01-03 [2a15d8630c], Just download from 2013-01-04 [5dc09927e3], test result is same.

<<Are you sure you did not define the LVCL conditional?>>
Yes, Just download and Extract File, not change anything.

<<Other problems comes directly from the fact that the system is MBCS, so ANSI functions are not consistent, and regression tests fail.>>

So this will not affect the real application, we can ignore these?

!  - IdemPropName: 1 / 10 FAILED  2.28ms
  Check(UpperCaseU(WinAnsiToUTF8('a殓D'))='AECD');  ==> Failed at 2121

!  - Soundex: 1 / 35 FAILED  175us
  Check(SoundExAnsi(' 123 bonjourtr'+chr(232)+'slongmotquid'+chr(233)+'passe  m',@PC)<>0);
  Check((PC<>nil) and (PC^=' '));  ==> Failed at 881, here PC^ is #168

!  - TPdfDocument: 1 / 2 FAILED  50.62ms
      Check(Hash32(MS.Memory,MS.Position)=Hash[embed]);  ==> Failed at 3971, left Hash32 is 3879243249, right hash is 394327692

!  - TPdfDocumentGDI: 1 / 3 FAILED  690.91ms

    i := PosEx('/FontBBox [',s);
    if CheckFailed(i=5650) then exit;  ==> Failed at 4132, here i is 5654

!  - TSQLRecord: 7 / 52 FAILED  1.22ms

    s := T.GetSQLValues;
    Check(s='Int,Test,Unicode,Ansi,ValFloat,ValWord,ValDate,Next,ValVariant '+
      'VALUES (0,'''','''','''',0,0,'''',0,null)');  ==> Failed at: 3304,  s is 'Int,Test,Unicode,Ansi,ValFloat,ValWord,ValDate,Next VALUES (0,'''','''','''',0,0,'''',0)'

    s := ObjectToJSON(T);
    Check(s='{"ID":0,"Int":0,"Test":"","Unicode":"","Ansi":"","ValFloat":0,'+
      '"ValWord":0,"ValDate":"","Next":0,"Data":"","ValVariant":null}');  ==>Failed at: 3308, s is '{"ID":0,"Int":0,"Test":"","Unicode":"","Ansi":"","ValFloat":0,"ValWord":0,"ValDate":"","Next":0,"Data":""}'

    T.ValDate := 39882.888612; // a fixed date and time
    T.Ansi := 'abcde'+chr(233)+'ef'+chr(224)+chr(233);
    T.Test := WinAnsiToUTF8('abcde'+chr(233)+'ef'+chr(224)+chr(233));
    T.Unicode := Utf8DecodeToRawUnicode(T.fTest);
    Check(RawUnicodeToWinAnsi(T.fUnicode)=T.fAnsi);  ==> Failed at:3315, here T.fUnicode is 'a'#0'b'#0'c'#0'd'#0'e'#0#$E9#0'e'#0'f'#0#$E0#0#$E9#0#0#0#0#0#$A8#0#0, T.fAnsi is 'abcdeéefàé'

    s := T.GetSQLSet;
    Check(s='Int=0, Test='''+T.Test+''', Unicode='''+T.Test+
      ''', Ansi='''+T.Test+''', ValFloat=3.141592653, ValWord=1203, '+
      'ValDate=''2009-03-10T21:19:36'', Next=0'{$ifdef USEVARIANTS}+
      ', ValVariant=''3.1416'''{$endif});  ==>Failed at:3324, s is 'Int=0, Test=''abcde茅ef脿茅'', Unicode=''abcde茅ef脿茅'', Ansi=''abcde茅ef脿茅'', ValFloat=3.141592653, ValWord=1203, ValDate=''2009-03-10T21:19:36'', Next=0'

    s := T.GetSQLValues;
    Check(Hash32(s)=$2D344A5E);  ==>Failed at 3329: s is 'Int,Test,Unicode,Ansi,ValFloat,ValWord,ValDate,Next VALUES (0,''abcde茅ef脿茅'',''abcde茅ef脿茅'',''abcde茅ef脿茅'',3.141592653,1203,''2009-03-10T21:19:36'',0)'

    s := T.GetJSONValues(false,true,soSelect);
    Check(s='{"fieldCount":10,"values":["RowID","Int","Test","Unicode","Ansi",'+
      '"ValFloat","ValWord","ValDate","Next"'{$ifdef USEVARIANTS}+
      ',"ValVariant"'{$endif}+',0,0,"'+T.Test+'","'+
      T.Test+'","'+T.Test+'",3.141592653,1203,"2009-03-10T21:19:36",0,'
      {$ifdef USEVARIANTS}+'3.1416'{$endif}+']}');  ==> Falied at 3331: s is '{"fieldCount":9,"values":["RowID","Int","Test","Unicode","Ansi","ValFloat","ValWord","ValDate","Next",0,0,"abcde茅ef脿茅","abcde茅ef脿茅","abcde茅ef脿茅",3.141592653,1203,"2009-03-10T21:19:36",0]}'

    s := ObjectToJSON(T);
    Check(s='{"ID":10,"Int":0,"Test":"'+T.Test+'","Unicode":"'+T.Test+
      '","Ansi":"'+T.Test+'","ValFloat":3.141592653,"ValWord":1203,'+
      '"ValDate":"2009-03-10T21:19:36","Next":0,"Data":""'{$ifdef USEVARIANTS}
        +',"ValVariant":3.1416'{$endif}+'}');  ==Failed at 3351:  s is '{"ID":10,"Int":0,"Test":"abcde茅ef脿茅","Unicode":"abcde茅ef脿茅","Ansi":"abcde茅ef脿茅","ValFloat":3.141592653,"ValWord":1203,"ValDate":"2009-03-10T21:19:36","Next":0,"Data":""}'

    T.Int := 1234567890123456;
    s := T.GetJSONValues(true,true,soSelect);
    Check(s='{"RowID":10,"Int":1234567890123456,"Test":"'+T.Test+'","Unicode":"'+T.Test+
      '","Ansi":"'+T.Test+'","ValFloat":3.141592653,"ValWord":1203,'+
      '"ValDate":"2009-03-10T21:19:36","Next":0,"ValVariant":3.1416}');  ==> Failed at 3363: s is '{"RowID":10,"Int":1234567890123456,"Test":"abcde茅ef脿茅","Unicode":"abcde茅ef脿茅","Ansi":"abcde茅ef脿茅","ValFloat":3.141592653,"ValWord":1203,"ValDate":"2009-03-10T21:19:36","Next":0}'

    s := T.GetJSONValues(true,true,soSelect);
    Check(s='{"RowID":10,"Int":1234567890123456,"Test":"'+T.Test+'","Unicode":"'+T.Test+
      '","Ansi":"'+T.Test+'","ValFloat":3.141592653,"ValWord":1203,'+
      '"ValDate":"2009-03-10T21:19:36","Next":0'{$ifdef USEVARIANTS}
      +',"ValVariant":"'+T.Test+'"'{$endif}+'}');  == Failed at: 3376, s is '{"RowID":10,"Int":1234567890123456,"Test":"abcde茅ef脿茅","Unicode":"abcde茅ef脿茅","Ansi":"abcde茅ef脿茅","ValFloat":3.141592653,"ValWord":1203,"ValDate":"2009-03-10T21:19:36","Next":0}'

    s := T.GetSQLSet;
    Check(s='Int=1234567890123456, Test='''+T.Test+''', Unicode='''+T.Test+
      ''', Ansi='''+T.Test+''', ValFloat=3.141592653, ValWord=1203, '+
      'ValDate=''2009-03-10T21:19:36'', Next=0'{$ifdef USEVARIANTS}+
      ', ValVariant='''+T.Test+''''{$endif});  ==> Failed at 3381, s is 'Int=1234567890123456, Test=''abcde茅ef脿茅'', Unicode=''abcde茅ef脿茅'', Ansi=''abcde茅ef脿茅'', ValFloat=3.141592653, ValWord=1203, ValDate=''2009-03-10T21:19:36'', Next=0'