mORMot Open Source

Hi Arnaud,

the Delphi compiler interprets ShortString as open array. And open arrays must not be used on inlined methods. Therefore it breaks on

procedure SidToTextShort(sid: PSid; var result: ShortString);
  {$ifdef HASINLINE}inline;{$endif}

Tested on Delphi 12.1 and 12.2

Regards,
Daniel

Hi Arnaud,

while we understand your thoughts behind making GetRttiVarData private, we run into a serious problem with that breaking change. We have written our own optimized data mappers, which heavily rely on that function. Using GetValueVariant would be possible, but we take a bad performance hit when using GetValueVariant. Would you mind, making it public again?

Regards,
Daniel

Hi arnaud,

VariantToText shall, according to doc, return false, if the variant ist empty or null false, otherwise it shall return true.
Following snippet returns false, though.

uses mormot.core.text;
var
  T: UTF8String;
begin
  Writeln(VariantToText(true, T));
  Writeln(T);
end.

In TRttiProp.SetValue this leads to not assigning a true-boolean value to a property.

Regards,
Daniel

GetValueByPath can easily handle a path such as 'Item.0,Name', where the second part is an array index.

However, when starting of an array with, 0.Name would work, if it were not for the check

  if (cardinal(VType) <> DocVariantVType) or
     (not IsObject) then

Changing that to

  if (cardinal(VType) <> DocVariantVType) or
     (not (IsObject or IsArray)) then

it works perfectly.

Regards,
Daniel

When streaming an object to Json, using

ObjectToJson(C, [woDontStoreDefault,woRawBlobAsBase64,woDontStoreVoid])

I ran into a problem, when a property is of type TObjectList.

Result: (Contained is published r/w property of type TObjectList:

// [woDontStoreDefault,woRawBlobAsBase64,woDontStoreVoid]
{"One":{"Name":"G"},"ID":42}

// [woDontStoreDefault,woRawBlobAsBase64]
{"One":{"Name":"G"},"ID":42,"Contained":[{"ClassName":"TOne","Name":"W"}]}

As soon as I omit woDontStoreVoid, it'll work just fine.

However, as I am trying to go through TInterfacedObjectFakeRaw.FakeCall -> TInterfacedObjectFake.FakeCallInternalProcess -> TInterfacedObjectFake.FakeCallGetJsonFromStack -> TInterfaceMethodArgument.AddJson (mocking in tests), Icannot control those parameters...

Regards,
Daniel

P.S.: A simple test project for this: https://filetransfer.io/data-package/C20KDkoc#link

Hi,

this change leads to an IPO in Delphi 12:
https://github.com/synopse/mORMot2/comm … e4356bc106

If I followed correctly, this leads Delphi to release the same memory twice.

I assign the text generated by GetAsText to a specific entry of a string array, and when that array is freed later on, I get the following error:

    "EInvalidPointer": {
      "ClassName": "EInvalidPointer",
      "Address": "7f0972d0",
      "Message": "Invalid pointer operation"
    }

Reverting that code into the previous version, everything works fine.

Regards,
Daniel

Today I got the following AV:

20230209 05111254 00000000AD4F394E  & EXCOS EAccessViolation (c0000005) [] at cc2926 
  mORMot.Net.Server.pas TUriTreeNode.RewriteUri (1729)  
  mormot.core.os.windows.inc GetModuleHandle (394) 
  mormot.core.os.windows.inc GetModuleHandle (394) 
  System.pas TMonitor.RemoveWaiter (20266) 
  System.Classes.pas ResetSyncEvent (15692) 
  System.pas @InitResStringImports (24792)

It happened only once with yesterdays mORMot2 sources. I cannot reproduce or give any hints as to when or why that happend. I simply started a mORMot-server and the AV happened. Restarting the server was without any problems.

I'll keep my eyes peeled, but wanted to put it out here in case anyone sees somethings similar or has any idea.

Sorry for being vague, but I can't tell more at this time :-(

Regards,
Daniel

It would help in many cases to have the simple declaration of

TSynAutoCreateFieldsClass = class of TSynAutoCreateFields

in mormot.core.json, thus freeing us from declaring it elsewhere :-)

Thanks,
Daniel

Hi,

in the current drop in mormot.core.data -> IniToObject
at line 4421 you reference rkGetIntegerPropTypes

Delphi 11 does not know this one.

Regards,
Daniel

Hi!

Is there already a way to grant access to registered factories to QuickJS scripts?

--Daniel