mORMot Open Source

I have solved the mistery

In PasZip.pas:

NameToIndex() is declared as this:

    function NameToIndex(const aName: AnsiString): integer;

but, is implemented as

function TZipRead.NameToIndex(const aName: string): integer;

Notice that 'AnsiString' has been replaced with 'string'.

It should, instead, be implemented as this:

function TZipRead.NameToIndex(const aName: AnsiString): integer;

---------------------

Another one is this:

    function UnZip(aIndex: integer): string; overload;

It should return 'AnsiString' instead of 'string'

IOW, it should be corrected to be:

    function UnZip(aIndex: integer): AnsiString; overload;

And, its implementation should be like this

function TZipRead.UnZip(aIndex: integer): AnsiString;
{snip}
begin
{snip}
      MessageBoxA(0,'CRC',Name,0);
{snip}
end;

---------------------

And, a little nitpick:

in 'function InflateFast()', there's this code. In there 'inc(R, Extra)' is redundant because 3 lines down, 'R' is assigned a value. See below.

              if C > Extra then begin
                // copy to end of window
                dec(C, Extra);
                MoveWithOverlap(R, Q, Extra);
                inc(R, Extra); { <--- REDUNDAT}
                inc(Q, Extra);
                // copy rest from start of window
                R := S.window;
              end;

---------------------

As you see, my focus has been on the unzipping side of things; I haven't looked ad zipping side of things at all.

But, having found the above AnsiString/string issues, I have become suspicious of routines such as 'function Zip()' as they seem to use 'string' a little too liberally.

But, I haven't checked them.