mORMot Open Source

esmondb

Member

From: London

Registered: 2010-07-20

Posts: 299

change to THttpServerGeneric.request

It seems that the function definition for THttpServerGeneric.request has recently changed and it no longer gets passed the full THttpServerSocket from the request. This has caused me a problem as I was deriving a class which needed the request headers and these aren't now available. Could request headers be added to the function def?
Thanks

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,240

Website

Re: change to THttpServerGeneric.request

I didn't add them because I didn't need them.

But you're right, they could be needed for some implementations (especially if you need to access cookies).

It was a bit verbose to implement it for Http.sys (because the api doesn't send back the header names for common entries: I had to use an hardcoded list).

But now you've got a new InHeaders incoming parameter to the Request event.

Sorry for the feature regression.
Thanks for your feedback.

esmondb

Member

From: London

Registered: 2010-07-20

Posts: 299

Re: change to THttpServerGeneric.request

Thanks for such a quick response. I'm on my way again! (you were right, I was using cookies)