#1 2016-07-15 13:16:26

mingda
Member
Registered: 2013-01-04
Posts: 121

Perhaps [2b444efbfd] commit is inverse

constructor THttpClientSocket.Create(aTimeOut: cardinal);
begin
  if aTimeOut = 0 then
    inherited Create(aTimeOut) else
    inherited Create(HTTP_DEFAULT_RECEIVETIMEOUT);
  UserAgent := DefaultUserAgent(self);
end;

perhaps should be

constructor THttpClientSocket.Create(aTimeOut: cardinal);
begin
  if aTimeOut = 0 then
    inherited Create(HTTP_DEFAULT_RECEIVETIMEOUT) else
    inherited Create(aTimeOut);

/*
  //or
  if aTimeOut = 0 then aTimeOut := HTTP_DEFAULT_RECEIVETIMEOUT;
  inherited Create(aTimeOut);
*/
  UserAgent := DefaultUserAgent(self);
end;

Offline

#2 2016-07-15 18:34:38

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,183
Website

Re: Perhaps [2b444efbfd] commit is inverse

Indeed.
See http://synopse.info/fossil/info/87bf0e8ccf

Pavel was a bit quick at pushing the latest patch.
wink

Offline

#3 2016-07-15 19:26:21

mpv
Member
From: Ukraine
Registered: 2012-03-24
Posts: 1,534
Website

Re: Perhaps [2b444efbfd] commit is inverse

Ups. Sorry

Offline

#4 2016-07-16 00:09:42

mingda
Member
Registered: 2013-01-04
Posts: 121

Re: Perhaps [2b444efbfd] commit is inverse

smile

Offline

#5 2016-07-19 08:13:14

mpv
Member
From: Ukraine
Registered: 2012-03-24
Posts: 1,534
Website

Re: Perhaps [2b444efbfd] commit is inverse

Another fix.  Let's OpenHttp use HTTP_DEFAULT_RECEIVETIMEOUT. See http://synopse.info/fossil/info/ad52326 … c4dea6adb4
I'm check my commit twice smile

Offline

Board footer

Powered by FluxBB