SynLog regression

mpv · 2018-04-13 08:13:02

@ab, there is regression in changed TSynLog.Log(TypeInfo()) to specify the value as const commit.
Now I can't compile code what use a call to Log with TextTruncateAtLength parameter

procedure Log(Level: TSynLogInfo; const Text: RawUTF8;
      Instance: TObject=nil; TextTruncateAtLength: integer=maxInt); overload;
// my code
  Ctxt.Log.Log(sllHTTP, Call.InBody, nil, 1024)

because it call match a

    procedure Log(Level: TSynLogInfo; const aName: RawUTF8;
      aTypeInfo: pointer; const aValue; Instance: TObject=nil); overload;

signature instead of version with TextTruncateAtLength ( FPC compiler)

Please, fix it in some way..

ab · 2018-04-13 11:42:06

if you get rid of the last =nil parameter default value?

mpv · 2018-04-13 12:01:14

Yes, if I remove default value in function below all work fine

procedure Log(Level: TSynLogInfo; const aName: RawUTF8;
      aTypeInfo: pointer; const aValue; Instance: TObject{=nil}); overload;

ab · 2018-04-13 12:42:20

Please check https://synopse.info/fossil/info/2d5aabb1d7

mpv · 2018-04-13 14:14:57

Now work as expected (both linux & windows FPC 3.1.1). Thanks!

Last edited by mpv (2018-04-13 14:15:08)

mpv · 2018-04-21 10:40:36

Another regression with the similar reason. In case

constructor TSynMemoryStreamMapped.Create(const aFileName: TFileName;
  aCustomSize: cardinal; aCustomOffset: Int64);

called with one argument (aFileName) then actual stream is created using

constructor TSynMemoryStream.Create(const aText: RawByteString);

and content of a stream is a file name, instead of file content.

Possible fix is in pull 107 (verified with FPC)

mORMot Open Source

#1 2018-04-13 08:13:02

SynLog regression

#2 2018-04-13 11:42:06

Re: SynLog regression

#3 2018-04-13 12:01:14

Re: SynLog regression

#4 2018-04-13 12:42:20

Re: SynLog regression

#5 2018-04-13 14:14:57

Re: SynLog regression

#6 2018-04-21 10:40:36

Re: SynLog regression

Board footer