mORMot Open Source

ssoftpro

Member

Registered: 2017-11-14

Posts: 7

Breaking changes in the latest mORMot

Dear Arno
When we updated to the latest commit, we encountered some breaking changes introduced:
1) TCrtSock.SockSendFlush procedure requires to set "body" parameter now. This does not correspond to the description of this function where this parameter described as optional. Should the function declaration be changed in the way body parameter has a default value of an empty string?
2) SetRawUTF8 function disappeared. Should we use FastSetString instead or what is your recommendations on the replacement?

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,238

Website

Re: Breaking changes in the latest mORMot

SockSendFlush() could accept a body to be send together with the pending data.
I've forgotten to put back the default parameter value.

FastSetString() is the new way to replace SetRawUTF8() and SetString(), together with FastSetStringCP() if you need to set an Ansi code page.
Especially with FPC, it is slightly faster than SetString().

Sorry for the breaking changes.

mpv

Member

From: Ukraine

Registered: 2012-03-24

Posts: 1,544

Website

Re: Breaking changes in the latest mORMot

@ab, something wrong with this commit https://github.com/synopse/mORMot/commi … 1892adbf9f It override prev. changes made by ssoftpro (in both repo). Im aready sync fossil and git todays morning