SynLog - To allow ignoring exceptions with code

edwinsn · 2018-09-25 14:31:23

Hello Arnaud,

To ignore certain exceptions I know there is alread the ExceptionIgnore property, but it's not very handy in case there are tons of exceptions to ignore.

For example in one of my programs which uses both mORMot and Indy, I definitely want SQLite3Log to intercept exceptions raised by the mORMot framework only but NOT exceptions caused by Indy.

But there are too much exceptions that's possible raised by Indy, so instead of calling ExceptionIgnore.Add() near one hundred times, I'd prefer to code some thing like

TMyChildSynLog = class(TSynLog)
  ...
  function IsExceptionIgnorable(aException: Exception): Boolean;
  ...
implementation
  ...
function TMyChildSynLog.IsExceptionIgnorable(aException: Exception): Boolean;
begin
  Result := aException.InheritesFrom(EIdException);
end;
  ...

Hope it makes sense.

ab · 2018-09-25 15:07:22

"Exceptions should be exceptional"... Indy didn't follow this pattern we like very much!

So you expect a callback event to check for the exception kind?
Or may a wildchar/glob TMatch on the class name suite you? E.g. to set 'EId*,EIndy*' in a parameter.

edwinsn · 2018-09-25 15:32:52

Hi ab,

I strongly strongly strongly prefer a callback event to check for the exception kind, it'll be much flexible! Thank you!

edwinsn · 2018-10-15 12:28:30

@ab,

I added such ability, if no problem please merge pull request I made just now: https://github.com/synopse/mORMot/pull/142

edwinsn · 2018-10-16 16:21:45

@ab,

Did you forget the pull request? I have made the changes as you requested

ab · 2018-10-16 17:34:37

Please check https://synopse.info/fossil/info/921511a12b

I have renamed it but the very same functionality.
Thanks for the pull request!

Chaa · 2018-10-17 04:11:14

/// callback signature used by TSynLogFamilly.OnBeforeException
// - should return true to log the exception, or false to ignore it
TSynLogOnBeforeException = function(aExceptionContext: TSynLogExceptionContext): boolean of object;

ab, please correct description: should return false to log the exception, or true to ignore it.

edwinsn · 2018-10-17 08:04:40

Thank you ab for merging it.

edwinsn · 2018-10-17 08:11:04

Chaa wrote:

/// callback signature used by TSynLogFamilly.OnBeforeException
// - should return true to log the exception, or false to ignore it
TSynLogOnBeforeException = function(aExceptionContext: TSynLogExceptionContext): boolean of object;

ab, please correct description: should return false to log the exception, or true to ignore it.

What's why I have originally named the event property as "HandleExceptionBeforeLogging", the keyword is "handle", because if it handle it, it should return True, and then TSynLog should ignore it

However I'm certainly OK with ab's new naming, but you are right, the comment you mentioned is wrong.

ab · 2018-10-17 10:31:13

Oups... sorry for the comment problem.

See https://synopse.info/fossil/info/24fedb6c83

edwinsn · 2018-10-22 05:02:48

@ab,

Is it possible to include the ID of the thread who's causing an exception with TSynLogExceptionContext? The thread ID can be helpful in the OnBeforeException event handler.

ab · 2018-10-22 06:26:31

The thread ID is returned by the OS API call.
Just call `GetCurrentThreadID`.

mORMot Open Source

#1 2018-09-25 14:31:23

SynLog - To allow ignoring exceptions with code

#2 2018-09-25 15:07:22

Re: SynLog - To allow ignoring exceptions with code

#3 2018-09-25 15:32:52

Re: SynLog - To allow ignoring exceptions with code

#4 2018-10-15 12:28:30

Re: SynLog - To allow ignoring exceptions with code

#5 2018-10-16 16:21:45

Re: SynLog - To allow ignoring exceptions with code

#6 2018-10-16 17:34:37

Re: SynLog - To allow ignoring exceptions with code

#7 2018-10-17 04:11:14

Re: SynLog - To allow ignoring exceptions with code

#8 2018-10-17 08:04:40

Re: SynLog - To allow ignoring exceptions with code

#9 2018-10-17 08:11:04

Re: SynLog - To allow ignoring exceptions with code

#10 2018-10-17 10:31:13

Re: SynLog - To allow ignoring exceptions with code

#11 2018-10-22 05:02:48

Re: SynLog - To allow ignoring exceptions with code

#12 2018-10-22 06:26:31

Re: SynLog - To allow ignoring exceptions with code

Board footer