mORMot Open Source

jaclas

Member

Registered: 2014-09-12

Posts: 215

SynCommons - little mistake in code

I found in SynCommons function:

function UnixMSTimePeriodToString(const UnixTime: TUnixTime; FirstTimeChar: AnsiChar='T'): RawUTF8;

The first parameter of this function should be of TUnixMSTime type and not of TUnixTime.
I know that these types are internally compatible, but in the future this may change and there will be trouble.

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,238

Website

Re: SynCommons - little mistake in code

Indeed.

Please check https://synopse.info/fossil/info/d23fc91df6