#1 2019-09-30 16:59:34

Eugene Ilyin
Member
From: milky_way/orion_arm/sun/earth
Registered: 2016-03-27
Posts: 132
Website

[FIXED] THttpApiServer.SetOnAfterResponse bug

Hi ab,

THttpApiServer.SetOnAfterResponse calls wrong inherited in 1.18.5387.

Please see the suggested fix in pull request #236

Can we do this method more useful (pull request #237)?

Also please add sqlite3.obj (usually used with the package) into .gitignore: pull request #238

Last edited by Eugene Ilyin (2019-10-01 13:06:30)

Offline

#2 2019-09-30 18:55:37

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,305
Website

Re: [FIXED] THttpApiServer.SetOnAfterResponse bug

I have merged your first two pull requests.

But we can't ignore sqlite3.obj - which is required for Delphi 32-bit.

Offline

#3 2019-10-01 01:27:45

Eugene Ilyin
Member
From: milky_way/orion_arm/sun/earth
Registered: 2016-03-27
Posts: 132
Website

Re: [FIXED] THttpApiServer.SetOnAfterResponse bug

No, I'm not suggest to remove sqlite3.obj from mORMot framework.
The pull request is just exclude this file from commits, uploads, etc. of GitHub project, because both files sqlite3.obj and sqlite3.o are provided separately from the framework.

Usually these files unpacked into root folder and GitHub repository add sqlite3.obj to all future commits which is uncomfortable and can be add to commit unintentionally.
.gitignore prevents such cases and remove this file from GitHub interest.

Btw, sqlite3.o file is already excluded with *.o template in line 46 of .gitignore file.
All I asked with this pull request is to be consistent and add sqlite3.obj as well.

Offline

#4 2019-10-01 08:07:44

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,305
Website

Re: [FIXED] THttpApiServer.SetOnAfterResponse bug

sqlite3.obj is provided in https://github.com/synopse/mORMot just like the other static files.

All those .o files are forced to be added manually at command line too.
See https://github.com/synopse/mORMot/tree/master/static: they were all properly updated 3 months ago with 3.29.0 revision of SQLite3.

This is clearly documented as such.
See https://synopse.info/files/html/Synopse … #TITLE_677 : "Advantage of cloning our GitHub repository is that it contains binaries for static linking, (SQLite3 and FPC specific), in a single step".

The manual download .7z files are used for fossil users (https://synopse.info/fossil) not github users.

Offline

#5 2019-10-01 13:06:03

Eugene Ilyin
Member
From: milky_way/orion_arm/sun/earth
Registered: 2016-03-27
Posts: 132
Website

Re: [FIXED] THttpApiServer.SetOnAfterResponse bug

I see, you add both sqlite3.obj and sqlite3.o files under /SQLite3 directory of GitHub project.
This pull request is pointless.

Thanks for clarification!

Offline

Board footer

Powered by FluxBB