#1 2021-06-18 10:14:24

tbo
Member
Registered: 2015-04-20
Posts: 339

Small changes to source code

mORMot2, Unit mormot.net.sock

In the source code there are places where the port value is passed as string and in other places as integer. Wouldn't it be better to change the DEFAULT_PORT definition as follows?

const  
  DEFAULT_PORT_STR: array[Boolean] of RawUtf8 = ('80', '443'); 
  DEFAULT_PORT_INT: array[Boolean] of Integer = (80, 443);

With best regards
Thomas

Offline

#2 2021-06-18 12:32:49

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,350
Website

Re: Small changes to source code

I have introduced DEFAULT_PORT_INT[Https] keepeind DEFAULT_PORT[Https] for backward compatibility.

Thanks for the feedback.

Offline

Board footer

Powered by FluxBB