mORMot Open Source

tbo

Member

Registered: 2015-04-20

Posts: 339

Error in commit cae3da1

Unit mormot.core.rtti
Error when compiling with Delphi 2007

There is an error in line 5298 in the definition of PT_RANDOM:

  // ptString,
  {$ifdef UNICODE} @_StringRandom, {$else} @_UStringRandom, {$endif}

The condition must be swapped.

With best regards
Thomas

Last edited by tbo (2021-07-20 21:14:14)

tbo

Member

Registered: 2015-04-20

Posts: 339

Re: Error in commit cae3da1

Delphi 2007 issues the following warning:

[DCC Warnung] mormot.rest.client.pas(1174): W1035 Rückgabewert der Funktion 'TRestClientAuthentication.ClientGetSessionKey' könnte undefiniert sein

If you move the result into the IF statement, the compiler no longer complains:

begin
  Sender.fSession.Data := ''; // reset temporary 'data' field
  result := '';
end

With best regards
Thomas

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,350

Website

Re: Error in commit cae3da1

Both should be fixed now.

Thanks for the feedback!