mORMot Open Source

tech

Member

Registered: 2014-01-13

Posts: 107

mORMot2 Regression Tests fails

Hi all,

I've tested the mormot v2.2 under Delphi12 and windows 10 and I got some failling regression tests :

 1.2. Core process:
...
!  - Encode decode JSON: 3 / 578,038 FAILED  1m03
!  - Mustache renderer: 5 / 62 FAILED  7m00
...
  Total failed: 8 / 936,795  - Core process FAILED  8m04

Regards,

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,238

Website

Re: mORMot2 Regression Tests fails

Are you connected to the Internet ?

These two tests need to download some json file from github as reference material.

tech

Member

Registered: 2014-01-13

Posts: 107

Re: mORMot2 Regression Tests fails

You're right, the VM doesn't have acces to the Internet, now all tests passed successfully.

Thank you AB.

TPrami

Member

Registered: 2010-07-06

Posts: 109

Re: mORMot2 Regression Tests fails

Hi all,

I've tested the mormot v2.2 under Delphi12 and windows 10 and I got some failing regression tests :

D12 has some nasty bugs, so there might be quite random stuff happening when running any code compiled with it.

Eagerly waiting for the update to it. Hope they really take their time tough, and squish all bugs they just can.

-Tee-

Last edited by TPrami (2024-01-05 04:48:10)

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,238

Website

Re: mORMot2 Regression Tests fails

@TPrami
Sad to hear, but interesting.
Do you have any references about those D12 bugs?
Are they about the IDE (instability, incompatibility), or the compiler itself?

TPrami

Member

Registered: 2010-07-06

Posts: 109

Re: mORMot2 Regression Tests fails

@TPrami
Sad to hear, but interesting.
Do you have any references about those D12 bugs?
Are they about the IDE (instability, incompatibility), or the compiler itself?

All over. Worst are the compiler problems.

new div optimization does not always work and maybe there was something in Mod also (Can't remember). IDE has broken features.

I think I saw following, could not reproduce after changed the code.
  function Foo: Ingeger; overload;
  function Foo(const AValue: Integer): Integer; overload;

Then I called Foo;, It was kind of Foo, but wirth 1 as default parameter. Then Called witrh Foo(0); and at least debugger went to the Foo; (without parameter). Made simple app but did not behave same way.

Collected few highly voted tickets.

https://quality.embarcadero.com/browse/RSP-43580
https://quality.embarcadero.com/browse/RSP-43424
https://quality.embarcadero.com/browse/RSP-43540
https://quality.embarcadero.com/browse/RSP-43485
https://quality.embarcadero.com/browse/RSP-43586
https://quality.embarcadero.com/browse/RSP-43445
https://quality.embarcadero.com/browse/RSP-43418
https://quality.embarcadero.com/browse/RSP-42692
https://quality.embarcadero.com/browse/RSP-43274

-Tee-

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,238

Website

Re: mORMot2 Regression Tests fails

Thanks!

I did not notice the new "division/modulo by a constant" compiler optimization in Delphi 12.
It was part of FPC since a lot of time, with great performance benefits - and a correct implementation.
I wrote about this years ago https://blog.synopse.info/?post/2015/06 … han-Delphi
and IIRC some people at Embarcadero did response at that time that it was nothing serious to be considerated.
... and now it is part of the compiler - with a buggy implementation.

A Delphi 12 hotfix seems on its way
https://quality.embarcadero.com/browse/ … ent-140624

Anyway, in mORMot, we try to work even with a broken UInt64 type implementation in the compiler. So we define our own QWord type (i.e. following the FPC naming), with a lot of dedicated functions, working correctly on every compiler.
Early Delphi did not properly handle it either, and even older Delphi versions did not have any UInt64 at all - just Int64.

TPrami

Member

Registered: 2010-07-06

Posts: 109

Re: mORMot2 Regression Tests fails

A Delphi 12 hotfix seems on its way

Time just crawls for the one who waits for the Delphi HotFix.
- Possibly Albert Einstein

-Tee-