mORMot Open Source

DonAlfredo

Member

Registered: 2023-10-31

Posts: 8

DocVariantToObject does not handle all fields

I am trying to use DocVariantToObject to fill an object from a variant.
Looking at the code.

if prop <> nil then
  prop^.Prop.SetValue(obj, doc.Values[p]);

This does not check the return-value of SetValue.
However, the return-value is false in case of complex fields.
So, when using this function with objects that contain classes like TCollection, then DocVariantToObject will not fill all fields.

Suggestion.

Valid := prop^.Prop.SetValue(obj,doc.Values[p]);
if (NOT Valid) then
begin
    json:=TDocVariantData(doc.Values[p]).ToJson;
    PropertyFromJson(prop,obj,pointer(json),Valid,JSONPARSER_TOLERANTOPTIONS);
end;

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,742

Website

Re: DocVariantToObject does not handle all fields

Please try
https://github.com/synopse/mORMot2/commit/ec529def

DonAlfredo

Member

Registered: 2023-10-31

Posts: 8

Re: DocVariantToObject does not handle all fields

Working 100%. Thanks !!

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,742

Website

Re: DocVariantToObject does not handle all fields

Thanks to YOU for your feedback and proposal!