mORMot Open Source

PierceNg

Member

From: Singapore

Registered: 2023-01-29

Posts: 14

Website

Minor: Typo and function signature clarification

Hi Arnaud,

1 - There's a typo in mormot.lib.curl.pas TCurlOptionName's coForbidResue; in curl.h, this option is CURLOPT_FORBID_REUSE.

2 - In mormot.orm.base.pas, TOrmTableAsbtract's property RowCount is declared as of type PtrInt, ditto the accessor function GetRowCount, but the function implementation returns the field fRowCount, declared type Integer. For clarity of intent, the signature of both RowCount and GetRowCount should return Integer. However, I see code in that unit doing comparisons with PtrUInt(fRowCount), so not sure. My program currently uses RowCount as a test for empty query result set which in its context means the program has opened an invalid SQLite database.

- Pierce