how is the best way to stop a HTTP server?

dorival · 2014-06-25 20:29:27

Hi,
I have one server (http api) and n clients.
My server is based on TSQLHttpServer, my client is based on TSQLHttpClient and some services that are consumed by clients.

Sometimes I need to stop de server, but I cannot just kill the server, 'cause maybe some important process are runing.

To stop the server I implemented:
- delete all users to stop new connections;
- wait that all request finished;
- and finally, freeandnil on my server object.

Below my code:

procedure TMyServer.StopServer;
var
  oSQLAuthUser: TSQLAuthUser;
begin
  oSQLAuthUser := TSQLAuthUser.Create;
  try
    oSQLAuthUser.FillPrepare(oSQLRestServerFullMemory);
    while (oSQLAuthUser.FillOne) do
      oSQLRestServerFullMemory.Delete(TSQLAuthUser, oSQLAuthUser.ID); // delete all users. This way I stop new clients connections.
  finally
    oSQLAuthUser.Free;
  end;
    while fDBServers[0].Server.Stats.ClientsCurrent > 0 do // until have clients, just wait...
      sleep(1000);
end;

And ...

procedure TMyServerAPP.StopServer;
begin
  fMyServer.StopServer;
  FreeAndNil(fMyServer);
end;

It's work... but I imagine that's not the best way to do this... Someone have any suggestion?
Thanks by your attention,

Dorival

Last edited by dorival (2014-06-25 20:30:23)

ab · 2014-06-25 21:17:03

Could you add a feature request as ticket, so that we implement a clean "shutdown" of a running server?

dorival · 2014-06-26 11:58:24

of course, it's done.

Thanks

ab · 2014-06-26 15:03:15

It has just been implemented as TSQLRestServer.Shutdown and TSQLHttpServer.Shutdown methods.
See http://synopse.info/fossil/info/4d4d2be … 8b328ae483

dorival · 2014-06-26 20:32:09

Thank you AB.

Chaa · 2014-06-27 04:00:55

A small note:
More correctly "shutting down", with two letters t.

ab · 2014-06-27 08:10:28

Typo is fixed.
Thanks!

mORMot Open Source

#1 2014-06-25 20:29:27

how is the best way to stop a HTTP server?

#2 2014-06-25 21:17:03

Re: how is the best way to stop a HTTP server?

#3 2014-06-26 11:58:24

Re: how is the best way to stop a HTTP server?

#4 2014-06-26 15:03:15

Re: how is the best way to stop a HTTP server?

#5 2014-06-26 20:32:09

Re: how is the best way to stop a HTTP server?

#6 2014-06-27 04:00:55

Re: how is the best way to stop a HTTP server?

#7 2014-06-27 08:10:28

Re: how is the best way to stop a HTTP server?

Board footer