TSynAnsiConvert.AnsiBufferTo* and #0 in the end

mpv · 2016-09-12 11:09:00

@AB - while implementing a nodeJS Buffer object (to be committed to SyNode) we discover a problem:
all TSynAnsiConvert.AnsiBufferTo* functions append a #0 to the end of Dest buffer. This is not good for our use cases - we need to modify a part of buffer and not break a rest.
Can I add a optional argument to the AnsiBufferTo* to prevent such behavior?

function AnsiBufferToUnicode(Dest: PWideChar; Source: PAnsiChar; SourceChars: Cardinal; ZeroTerminate: boolean = true): PWideChar; overload; virtual;
begin
...
  if ZeroTerminate then result^ := #0;
end;

ab · 2016-09-12 12:23:40

Please check http://synopse.info/fossil/info/e7239c9081

mpv · 2016-09-12 15:20:21

Thanks! The first check is OK..
Please, review the commit [86ecc83b65]- we add a REPLACEMENT CHARACTER (0xEF 0xBF 0xBD for UFT8) for unmathced surrogate pairs during RawUnicodeToUtf8
This version is pass nodeJS buffer tests, but may be you decide to rewrite in more "mORMot" way

Last edited by mpv (2016-09-12 15:22:53)

ab · 2016-09-13 07:41:03

Please try http://synopse.info/fossil/info/33568686fd
and http://synopse.info/fossil/info/60826e6664

mpv · 2016-09-13 11:50:02

I add small changes - see http://synopse.info/fossil/info/7043499 … 71277de61d (and [81ebdcdf6d] - I don't understand how I rewrite your changes - looks like fossil merge not ideal)

mpv · 2016-09-13 12:02:44

Ups. This is not fossil merge - this is my Subversion. AB - let's merge a WinWebSocket & HTTPServerEvents to the trunk. This changes not break your code, but add a low-level HTTP.SYS based WebSockets (allow many WS client connections - we currently have near 5000 in production and WSS). Because I work in WinWebSocket brunch I can't use a fossil repo directly and need to copy mORMot to the my subversion repo. This complicates my life for every mORMot repo commit

mpv · 2018-03-01 08:06:38

I'm simplify condition for replacing unmatched surrogate pairs during RawUnicodeToUtf8 - please, see fix for FPC compiler. Delphi and FPC compiler unexpectedly differs for me...

mORMot Open Source

#1 2016-09-12 11:09:00

TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#2 2016-09-12 12:23:40

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#3 2016-09-12 15:20:21

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#4 2016-09-13 07:41:03

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#5 2016-09-13 11:50:02

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#6 2016-09-13 12:02:44

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

#7 2018-03-01 08:06:38

Re: TSynAnsiConvert.AnsiBufferTo* and #0 in the end

Board footer