Fix to timestamp bug regression

EMartin · 2017-04-26 16:15:55

Hi @ab, this fix https://synopse.info/fossil/info/f69f5eb7d2ed6541 introduced a bug with error "Invalid point operation".

your fix:

...
  ftDate, ftTime, ftDateTime:
    if PDateTime(Data)^=0 then
      result := false else begin
      TS := DateTimeToTimeStamp(PDateTime(Data)^);
      if (TS.Time<0) or (TS.Date<=0) then
        result := false else // matches ValidateTimeStamp() expectations
        case Field.DataType of
        ftDate:     PDateTimeRec(Dest)^.Date := TS.Date;
        ftTime:     PDateTimeRec(Dest)^.Time := TS.Time;
        ftDateTime: PDateTimeRec(Dest)^.DateTime := TimeStampToMSecs(TS) //-->> YOUR FIX !!!
        end;
    end;
  ftString: begin
...

the solution:

...
  ftDate, ftTime, ftDateTime:
    if PDateTime(Data)^=0 then
      result := false else begin
      TS := DateTimeToTimeStamp(PDateTime(Data)^);
      if (TS.Time<0) or (TS.Date<=0) then
        result := false else // matches ValidateTimeStamp() expectations
        case Field.DataType of
        ftDate:     PDateTimeRec(Dest)^.Date := TS.Date;
        ftTime:     PDateTimeRec(Dest)^.Time := TS.Time;
        ftDateTime: PDateTimeRec(Dest)^.DateTime := PDateTime(Data)^; //-->> THE SOLUTION !!!
        end;
    end;
  ftString: begin
...

this correction working for me, but I can be wrong.

Best regards.

ab · 2017-04-26 18:58:49

Please check https://synopse.info/fossil/info/38a40616cc

EMartin · 2017-04-26 19:39:31

works fine.

Thanks.

Junior/RO · 2017-04-30 22:38:10

That don't works for me. The @ab solution works.

ftDateTime: PDateTimeRec(Dest)^.DateTime := TimeStampToMSecs(TS);

^this works

Chris75018 · 2017-05-19 14:05:26

That don't works for me too.
The @ab solution works.

--> ftDateTime: PDateTimeRec(Dest)^.DateTime := TimeStampToMSecs(TS);

If TS have not Time part (TS.Time = 0) then PDateTime(Data)^ doesn't have a valid date.

I used DataSetToJSON(MyInterbaseQuery) to store data in RawUTF8 buffer.
I reload data with TSynSQLTableDataSet.CreateFromJSON(nil, MyBuffer, MyTSQLFieldsType)

Junior/RO · 2017-05-20 15:33:23

@ab what you think?

EMartin · 2017-05-20 15:52:56

my solution solved my problem with new data but not with existing, I can confirm that the bug regression still exists.

ab · 2017-07-25 19:22:08

Please try https://synopse.info/fossil/info/d171280064

I've reverted to the previous version, which was reported to work - but for EMartin...

mORMot Open Source

#1 2017-04-26 16:15:55

Fix to timestamp bug regression

#2 2017-04-26 18:58:49

Re: Fix to timestamp bug regression

#3 2017-04-26 19:39:31

Re: Fix to timestamp bug regression

#4 2017-04-30 22:38:10

Re: Fix to timestamp bug regression

#5 2017-05-19 14:05:26

Re: Fix to timestamp bug regression

#6 2017-05-20 15:33:23

Re: Fix to timestamp bug regression

#7 2017-05-20 15:52:56

Re: Fix to timestamp bug regression

#8 2017-07-25 19:22:08

Re: Fix to timestamp bug regression

Board footer