#1 2017-02-10 23:28:06

Junior/RO
Member
Registered: 2011-05-13
Posts: 202

git bisect: 4b1ef819c6f1d76801be is the first bad commit

@ab

Since november that I haven't updated mORMot. I have a program that uses TSynVirtualDataSet and everything worked OK. Today, after a git pull, the exception is

Project test.exe raised exception class EConvertError with message ''0.42768' is not a valid timestamp'. Process stopped. Use Step or Run to continue.

git bisect says the the error is with commit 4b1ef819c6f1d76801bee1896a859a6d08d15f00. Commit message "new GetDBFieldDef and GetDBFieldValue functions to ease filling of any TDataSet from a TSQLTable content". Commit date is january, 23.

The error is in SynVirtualDataset.pas, line 406:TSynVirtualDataSet.GetFieldData. Exception is raised with a Field.DataType = ftDateTime.

This is a bug or a breaking change?

Thank you.

--
Delphi 7, Windows 10, locale brazilian-portuguese, pagecode Windows 1252.

Last edited by Junior/RO (2017-02-10 23:43:58)

Offline

#2 2017-02-10 23:55:13

EMartin
Member
From: Buenos Aires - Argentina
Registered: 2013-01-09
Posts: 332

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

I had the same problem, in my last update the SynRestDataset.pas I had patch the dataconvert method.


Esteban

Offline

#3 2017-02-13 14:05:16

StxLog
Member
From: France
Registered: 2015-09-14
Posts: 58

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

We had the same problem too. See https://synopse.info/forum/viewtopic.php?id=3807 for our fix.

Offline

#4 2017-02-14 09:10:46

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 13,274
Website

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

Offline

#5 2017-02-15 00:03:42

Junior/RO
Member
Registered: 2011-05-13
Posts: 202

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

The exception still raising in the function TSynVirtualDataSet.GetFieldData().

Offline

#6 2017-02-15 07:53:52

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 13,274
Website

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

With which data?

Offline

#7 2017-02-15 13:10:33

Márcio Baroni
Member
From: Brasil
Registered: 2015-10-07
Posts: 21

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

Hi, I'm with the same problem ...
I'm turning json to a DataSet to use in a report with ReportBuilder .... but in the last commits this was broken. "JSONToDataSet" from mORMotVCL.pas
I had to switch to "ToClientDataSet" from mORMotMidasVCL.pas to work.

Offline

#8 2017-02-15 13:34:52

Junior/RO
Member
Registered: 2011-05-13
Posts: 202

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

I will provide a test case.

Offline

#9 2017-02-15 14:59:02

EMartin
Member
From: Buenos Aires - Argentina
Registered: 2013-01-09
Posts: 332

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

@ab, I had same issue and I had patch Delphi code, in my post https://synopse.info/forum/viewtopic.ph … 287#p23287 I detailed some corrections (exclude ftModTime, ftCreateTime new implementation as datetime field in a dataset).


Esteban

Offline

#10 2017-04-06 11:26:29

mbadstones
Member
Registered: 2017-04-01
Posts: 5

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

I have this problem
EconvertError with message "0.42831" is a not valid timestamp
with JSONToClientDataSet and ToClientDataSet

Offline

#11 2017-07-25 19:22:34

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 13,274
Website

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

Please try https://synopse.info/fossil/info/d171280064

I've reverted to the previous version, which was reported to work - but for EMartin...

Offline

#12 2017-07-28 16:49:20

Junior/RO
Member
Registered: 2011-05-13
Posts: 202

Re: git bisect: 4b1ef819c6f1d76801be is the first bad commit

Many thanks

Offline

Board footer

Powered by FluxBB