Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

EMartin · 2018-02-08 18:57:12

Hi @ab, I think that I found bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant, how I can
reproduce them I generated an application test case and I put it in https://drive.google.com/open?id=1kBpGl … yWlSm8-GkX.

The second and third button reproduce the problems and in ToDocVariant checking the "Workaround" checkbox solve the same.

Can you verify this please ?

Thanks.

EMartin · 2018-02-09 13:12:08

@ab, can you see this ?

Thanks.

ab · 2018-02-10 14:57:23

Please check https://synopse.info/fossil/info/e6744742ea for the first one.

I will look also into the 2nd potential problem.

ab · 2018-02-11 17:14:20

The ToDocVariant was much more difficult to track...
The Delete operation did modify the TSQLTable.fFieldNames[] content, which was copied by reference to the TDocVariant.

Should be fixed by https://synopse.info/fossil/info/3df34f09d2

EMartin · 2018-02-14 13:57:39

Thanks @ab, all works fine.

EMartin · 2018-02-14 20:06:02

Sorry @ab, but in the last fixes have been introduced a bug when saving objects to JSON from TDynArray. In https://drive.google.com/open?id=1qCR1x … jx4ev2wLbK I added a button DynArrayObj that plays the fail case.

For me application, this bug is a breaking change and I need that works as before.

UPDATE:

I have the following interface based service:

function ImportTable(cosnt aCSVOptions: TCDICSVOptions; const aTableOptions: TCDITableOptions; const aMapFieldOptions: TCDIMapFieldOptionArray): TServiceCustomAnswer;

and before the fixes this services worked ok, but after the same the server receives the aMapFieldOptions parameter of the same way that the reproduced fail test case.

Thanks in advance.

Last edited by EMartin (2018-02-14 20:42:21)

EMartin · 2018-02-15 12:17:12

Sorry @ab for my insistence, can you see this issue ?

Thanks.

EMartin · 2018-02-15 14:18:36

I found the error in my test case, I forgot this code:

TJSONSerializer.RegisterObjArrayForJSON(TypeInfo(TCDIMapFieldOptionArray), TCDIMapFieldOption);

I don't understand why the JSON serialization in interface based service is not working more. That's is my big problem.

I'all appreciate any help.

mORMot Open Source

#1 2018-02-08 18:57:12

Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#2 2018-02-09 13:12:08

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#3 2018-02-10 14:57:23

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#4 2018-02-11 17:14:20

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#5 2018-02-14 13:57:39

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#6 2018-02-14 20:06:02

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#7 2018-02-15 12:17:12

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

#8 2018-02-15 14:18:36

Re: Possible bugs in TSQLTable.GetJSONValues and TSQLTable.ToDocVariant

Board footer