TSynLog should ignore exceptions wrapped by try...except block

edwinsn · 2018-04-21 02:35:01

Hi ab,

By default TSynLog automatically logs any exceptions raised and this is a nice feature, but I think it should ignore exceptions wrapped by any empty 'try...except' block. I guess it's a common practice to use a try...except block to "eat" some exceptions, for example:

    try
      // do something and if any exception raises just ignore them.
    except
      // ignore all exceptions here.
    end;

ab · 2018-04-21 21:28:56

It is another feature, at application level.

But IMHO exceptions should be exceptional.
See http://blog.synopse.info/post/2015/04/1 … -good-idea

edwinsn · 2018-04-22 02:41:02

@ab,

Sorry if I didn't make it clear - here I'm talking about the server side only. Like this:

function: TMyServerSideInterface.Method1: Integer;
begin
    // Point A
    try
      // do something.
    except // Point B
      // ignore all exceptions here.
    end;
end;

But the engine still logs exceptions raised between Point A and Point B.

ab · 2018-04-26 16:14:49

Yes, it is as designed, and expected.
If the server code raises exceptions in "normal" process, then it is a design issue, and should be fixed.

On the server side, the exceptions should better always be cought by an "except...end" block, anyway.
So for your need, you could just remove exception logging from the SynLog levels.
But you will definitively miss a nice feature.

edwinsn · 2018-04-26 17:22:28

@ab,

There are times some exceptions can be ignored, for example, sending an email on the server-side, we might want to catch the 'internet error' and re-try again later.

On the other hand, it'll fix the issue if EchoCustom can tell TSynLog to ignore a given log entry.

EMartin · 2018-04-26 17:28:54

@edwinsn I use TSynLog.Family.ExceptionIgnore.Add(ExceptionXXX), it is not useful for you ?

edwinsn · 2018-04-27 03:11:30

@EMartin,

Oops! I missed that feature, thanks! I think it's enough for now.

mORMot Open Source

#1 2018-04-21 02:35:01

TSynLog should ignore exceptions wrapped by try...except block

#2 2018-04-21 21:28:56

Re: TSynLog should ignore exceptions wrapped by try...except block

#3 2018-04-22 02:41:02

Re: TSynLog should ignore exceptions wrapped by try...except block

#4 2018-04-26 16:14:49

Re: TSynLog should ignore exceptions wrapped by try...except block

#5 2018-04-26 17:22:28

Re: TSynLog should ignore exceptions wrapped by try...except block

#6 2018-04-26 17:28:54

Re: TSynLog should ignore exceptions wrapped by try...except block

#7 2018-04-27 03:11:30

Re: TSynLog should ignore exceptions wrapped by try...except block

Board footer