#1 2020-02-05 13:21:23

slapshot
Member
Registered: 2020-01-21
Posts: 14

Patching the examples sources

Hello, in my attempt to have a deep understand of your great framework I'm studying example sources. I'm using FPC and Lazarus, mainly under Linux, and often I find that examples are missing of lpi/lpr project or does not compile because some directives are not working etc..

Following the hints of your handbook I have a fossil working copy on my pc of synopse repository. Is there a way to produce a patch when I modify examples source so they can compile on Linux ?

Thank you

Offline

#2 2020-02-05 15:22:13

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,182
Website

Re: Patching the examples sources

There is no "pull request" possible with fossil.

User usually use https://github.com/synopse/mORMot

Offline

#3 2020-02-05 17:05:33

slapshot
Member
Registered: 2020-01-21
Posts: 14

Re: Patching the examples sources

Thank you ! I got an svn chekout of the git repository but I'm not able anymore to compile mormot_base laz package. mORMot.pas file in row 9085 and 9086 and 9109 and 9110 has an override of IntGet and IntSet method which are differents from its ancestor.

code example
https://pastebin.com/7Pyt8reD

Thank you

Last edited by slapshot (2020-02-05 17:06:01)

Offline

#4 2020-02-05 17:43:32

Márcio Baroni
Member
From: Brasil
Registered: 2015-10-07
Posts: 28

Re: Patching the examples sources

@ab I have noticed several times that some changes made to the fossil are not synchronized with github.

https://pasteboard.co/ITj5s5A.jpg

https://pasteboard.co/ITj5SWo.jpg

Last edited by Márcio Baroni (2020-02-05 18:01:09)

Offline

#5 2020-02-05 17:45:54

slapshot
Member
Registered: 2020-01-21
Posts: 14

Re: Patching the examples sources

I don't know this, too early for me to understand this huge code ! big_smile . I checked via svn revision 8005 and 8004. There is a new parameter NameLen that there is not into abstract ancestor class.

Offline

#6 2020-02-06 18:03:04

wai-kit
Member
From: Amsterdam, the Netherlands
Registered: 2012-11-27
Posts: 90

Re: Patching the examples sources

I got the same error for IntGet and IntSet. I used the Github version.
I downloaded the NightlyBuild from : https://synopse.info/fossil/wiki?name=Get+the+source
Now, the package compiles.

I am using Lazarus 2.1.0 r62611 and FPC 3.3.1 on Windows. My target is i386-win32


fpcdeluxe, FPC 3.2 / Lazarus 2.0, mORMot on Windows 10 ...

Offline

#7 2020-02-06 18:07:02

slapshot
Member
Registered: 2020-01-21
Posts: 14

Re: Patching the examples sources

I updated my working copy of Fossil and now it compiles. No problem at all. Maybe some sync troubles between repositories.

Thank you

Offline

#8 2020-02-06 21:06:24

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,182
Website

Re: Patching the examples sources

Should be fine on github now.

I use rsynch to copy changes to my github repo from the fossil reference repository.
See https://github.com/synopse/mORMot/blob/ … tCommit.sh

Sometimes, it doesn't find the modifications! I don't see why...
Under Windows, I used RoboCopy https://github.com/synopse/mORMot/blob/ … Commit.bat which worked well...

If anyone knows a better way under Linux to synchronize one folder from another...

Offline

#9 2020-02-06 21:12:06

slapshot
Member
Registered: 2020-01-21
Posts: 14

Re: Patching the examples sources

ab wrote:

If anyone knows a better way under Linux to synchronize one folder from another...

Well rsync is really a great tool and it is very difficult to fail. Which switch are you using to sync both repository ?

Offline

#10 2020-02-06 21:20:44

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,182
Website

Re: Patching the examples sources

The link of the bash file is in my post.

Offline

#11 2020-02-06 21:48:29

slapshot
Member
Registered: 2020-01-21
Posts: 14

Re: Patching the examples sources

Sorry I did not have seen that.

It seems all ok, that's a weird behaviour of rsync.

Offline

Board footer

Powered by FluxBB