#1 2020-12-29 14:45:20

IBE Software
Member
Registered: 2020-12-29
Posts: 5

Patch to fix SynPDF exception and add support for rotated texts

The current version of SynPDF raises an exception when rotated text is drawn from an EMF file: https://github.com/synopse/SynPDF/issues/42
Here is a patch to fix this exception and add support for rotated texts in SynPDF: https://github.com/synopse/SynPDF/issue … -752101479
It has been developed by "Kukhtin Igor" and sponsored by the HelpNDoc help authoring tool.

Last edited by IBE Software (2020-12-29 15:19:10)

Offline

#2 2020-12-29 14:49:09

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,659
Website

Re: Patch to fix SynPDF exception and add support for rotated texts

Great!

Could you please provide a pull request on GitHub?

Online

#3 2020-12-29 15:30:02

IBE Software
Member
Registered: 2020-12-29
Posts: 5

Re: Patch to fix SynPDF exception and add support for rotated texts

Offline

#4 2020-12-29 15:44:07

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,659
Website

Re: Patch to fix SynPDF exception and add support for rotated texts

Thanks a lot.

I have merged it.

Online

#5 2020-12-30 09:07:47

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,659
Website

Re: Patch to fix SynPDF exception and add support for rotated texts

Your patch don't compile!

c180divPI and pi constant are not known.

Online

#6 2020-12-30 09:19:10

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,659
Website

Re: Patch to fix SynPDF exception and add support for rotated texts

Those constants were not defined in earlier Delphi revisions.

I have fixed them.

https://synopse.info/fossil/info/d02e3bc624

Online

#7 2020-12-30 10:38:15

IBE Software
Member
Registered: 2020-12-29
Posts: 5

Re: Patch to fix SynPDF exception and add support for rotated texts

Oh sorry about that, we only tested on recent versions of Delphi and do not have any older versions installed.

Offline

#8 2020-12-30 13:46:07

ab
Administrator
From: France
Registered: 2010-06-21
Posts: 14,659
Website

Re: Patch to fix SynPDF exception and add support for rotated texts

No problem, I was just afraid at first it was not part of any Delphi RTL.

Online

Board footer

Powered by FluxBB