mORMot Open Source

jairgza

Member

Registered: 2015-01-15

Posts: 10

DocVar GetValueByPath raise EDocVariant property not found

Hi

According to docs GetValueByPath will return Unassigned if the path does not match with the docvar content, so it seems an easy way to read optional nodes

But this code raises "Exception class EDocVariant with message '[Imps] property not found'. "

v := _Obj([ 'Config', _Obj([]) ]);

m := _Safe(v).GetValueByPath('Config.Imps');

if VarIsEmptyOrNull(m) then
    ShowMessage('error');

I try this code too:

v := _Obj([ 'Config', _Obj([]) ]);

if not _Safe(v).GetValueByPath('Config.Imps', m) then
    ShowMessage('error');

I can use [dvoReturnNullForUnknownProperty] option but I prefer not, and be more strict and use late binding for required properties (expecting exceptions if not exist) and try read/validate optional nodes with GetValueByPath

Is it the correct behavior ?

thanks

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,655

Website

Re: DocVar GetValueByPath raise EDocVariant property not found

You are right.

GetValueByPath() should not raise an exception but return false.
I have just updated TDocVariant.Lookup() to reflect this behavior.

macfly

Member

From: Brasil

Registered: 2016-08-20

Posts: 374

Re: DocVar GetValueByPath raise EDocVariant property not found

hi ab,

Using the same topic about tdocvariant.

From certain decimal places on a double value json is no longer recognized as valid.
Is this expected behavior?

NOTE: I know about the loss of precision, and that I can use the dvoAllowDoubleValue option. Just checking if it's expected.

v := _JSON('{"value":0.001}'); //ok
v := _JSON('{"value":0.00001}');  //not recognized as valid json

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,655

Website

Re: DocVar GetValueByPath raise EDocVariant property not found

Yes, it is as expected.
Just use _JsonFastFloat() or dvoAllowDoubleValue.

jairgza

Member

Registered: 2015-01-15

Posts: 10

Re: DocVar GetValueByPath raise EDocVariant property not found

You are right.

GetValueByPath() should not raise an exception but return false.
I have just updated TDocVariant.Lookup() to reflect this behavior.

Thanks for your quick respond,  I see the fix in mormot2
but not in 1.18 , Im using that version,  sorry I did not mention it