mORMot Open Source

tbo

Member

Registered: 2015-04-20

Posts: 353

TOrmProperties.FieldBitsFromRawUtf8()

Concerns mORMot2:

The description still refers to the old function name "TOrmProperties.FieldBitsFromRawUtf8()" in several places.

With best regards
Thomas

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,659

Website

Re: TOrmProperties.FieldBitsFromRawUtf8()

Indeed.

Should be fixed now.

tbo

Member

Registered: 2015-04-20

Posts: 353

Re: TOrmProperties.FieldBitsFromRawUtf8()

Should be fixed now.

It should be called (commit e85ca80):

function TOrmPropertiesAbstract.FieldBitsFromRawUtf8(
  const aFields: array of RawUtf8; var Bits: TFieldBits): boolean;
begin
  result := FieldBitsFrom(aFields, Bits);
end;

A personal note: I don't think it's necessary to keep the FieldBitsFromRawUtf8() function. mORMot2 is not officially released yet and everyone who already uses it must know that there can/will be changes. I'm happy to make these changes.

With best regards
Thomas

tbo

Member

Registered: 2015-04-20

Posts: 353

Re: TOrmProperties.FieldBitsFromRawUtf8()

mORMot2, commit a96bc2d

I think my comments from post #3 are still there.

With best regards
Thomas

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,659

Website

Re: TOrmProperties.FieldBitsFromRawUtf8()

You are right, there was an infinite loop!

Should be fixed now.
Thanks for the feedback.