mORMot Open Source

PBa

Member

From: Austria

Registered: 2017-01-04

Posts: 18

Typing errors in TTestCoreCrypto.Catalog

Dear ab,

IMHO there are two typing errors in TTestCoreCrypto.Catalog:

1) line 2175: c2.GetSerial instead of c1.GetSerial

    Check(c1.IsEqual(c2));
    CheckEqual(c1.GetSerial, c1.GetSerial);   //  <== should be replaced by: CheckEqual(c2.GetSerial, c1.GetSerial);
    CheckEqual(c2.GetSubject, c1.GetSubject);

1) line 2220: c2.Instance.ClassType instead of c3.Instance.ClassType

    c2 := st1.CertAlgo.New;
    Check(c3.Instance.ClassType = c1.Instance.ClassType);  //  <== should be replaced by: Check(c2.Instance.ClassType = c1.Instance.ClassType);
    c2.Generate([cuCA], '', c1);

Thank you!
Best regards and all the best for 2022!
Paul

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,659

Website

Re: Typing errors in TTestCoreCrypto.Catalog

You are right, of course.
Should be fixed by https://github.com/synopse/mORMot2/commit/6c023a36

Thanks for the feedback!