SetPropsFromText and TArray<...>

sakura · 2022-09-22 08:57:11

Hi,

in Delphi, there is the possibility to declare arrays using TArray<...> rather than array of ..., which has a few advantages.

However, TRttiCustom.SetPropsFromText only handles array of ..., when parsing a string of properties.

When using code such as

  OrigRtti := Rtti.RegisterClass(aOrmClass);
  for var Prop in OrigRtti.Props.List do
      PropText := PropText + ';' + Prop.Name + ':' + Prop.Value.Name;

Prop.Value.Name will return TArray<...> when declared in that way.

Is there a fair chance of getting TRttiCustom.SetPropsFromText to work with TArray<...>, which from a mORMot pov would be the same, as array of ... ?

Regards,
Daniel

ab · 2022-09-22 13:34:16

TArray<..> syntax should already be handled by SetPropsFromText().

See line 7900 and following of mormot.core.rtti.

sakura · 2022-09-22 14:58:38

Hm, it crashed on me today, I'll give more details tomorrow. Had just shut down my VM. :-D

Thanks,
Daniel

sakura · 2022-09-23 09:06:07

Here is a simple sample, breaking with TArray<...>, working with array of ...

https://pastebin.com/JyzF67hN

Enable/Disable lines 14&17 to see difference.

sakura · 2022-09-23 09:10:05

Checking into it (ln 7900)
alen = 6
aname = 'TArray'

so, Typename does not contain the expected 'TArray<TPpCallSecurityRight>, but simply TArray.

sakura · 2022-09-23 09:13:49

Digging deeper, you call GetNextFieldProp, which in turn only selects alphanumeric and underscores

  while tcIdentifier in tab[P^] do
    inc(P); // go to end of ['_', '0'..'9', 'a'..'z', 'A'..'Z'] chars

Therefore, the <....> part never becomes part of the typename, therefore failing the test in lns 9000+

Regards,
Daniel

ab · 2022-09-23 15:35:06

You are right.

Please try with https://github.com/synopse/mORMot2/commit/8c52628d

sakura · 2022-09-26 06:36:08

While this part works now, I have noticed another small, Delphi specific glitch around that. From the original sample code, I used

Prop.Value.Name

to get the type.
When using TArray it propagate as

TArray<Unitname.Typename.SubTypeName>

Due to including the unit name, FindType will not recognize the Type. Should prop value name be handled specific in that case?

I uploaded example it would generate

SomeStr: UTF8String;Fail:TArray<Decl.TPpCallSecurityRight>;

<-- note the Decl.

Regards,
Daniel

ab · 2022-09-26 08:41:29

The problem is that in mormot.core.rtti the type name is expected to be unique globally.
We could remove the unit name, but if there are several TPpCallSecurityRight types defined, it would only find the first declared, which may not be in Decl...
See https://github.com/synopse/mORMot2/commit/3df95e4a

But it is likely not to work with Delphi specific Typename.SubTypeName type definitions.

mORMot Open Source

#1 2022-09-22 08:57:11

SetPropsFromText and TArray<...>

#2 2022-09-22 13:34:16

Re: SetPropsFromText and TArray<...>

#3 2022-09-22 14:58:38

Re: SetPropsFromText and TArray<...>

#4 2022-09-23 09:06:07

Re: SetPropsFromText and TArray<...>

#5 2022-09-23 09:10:05

Re: SetPropsFromText and TArray<...>

#6 2022-09-23 09:13:49

Re: SetPropsFromText and TArray<...>

#7 2022-09-23 15:35:06

Re: SetPropsFromText and TArray<...>

#8 2022-09-26 06:36:08

Re: SetPropsFromText and TArray<...>

#9 2022-09-26 08:41:29

Re: SetPropsFromText and TArray<...>

Board footer