mORMot Open Source

zen010101

Member

Registered: 2024-06-15

Posts: 106

Issue about ConsoleWrite()

Look at this, where the Writeln statement outputs the correct string, but ConsoleWrite does not.
The reason is that ConsoleWrite internally calls Utf8ToConsole, which converts the string from UTF8 to CP_OEM.
The Writeln function will internally determine whether the code page of the Output is UTF8, and convert the string only if it is not.

code is here: https://gist.github.com/zen010101/fb6cb … le-bug-pas

I committed a PR for this: https://github.com/synopse/mORMot2/pull/337

Last edited by zen010101 (2025-01-26 09:23:23)

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,934

Website

Re: Issue about ConsoleWrite()

I guess the right fix may be
https://github.com/synopse/mORMot2/commit/57593aa61

Thanks for the feedback.

zen010101

Member

Registered: 2024-06-15

Posts: 106

Re: Issue about ConsoleWrite()

It works! The only disadvantage may be that the API is only called once, which is not very friendly to programs that adjust ConsoleOutputCP multiple times. However, this is also a balance between correctness and performance, which is understandable and acceptable.

Thanks again to ab.

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,934

Website

Re: Issue about ConsoleWrite()

In fact, ConsoleOutputCP() makes a syscall, so it is slow.

If you call AllocConsole, it will reset the internal cache:
https://github.com/synopse/mORMot2/commit/a7223d8b6