mORMot Open Source

mrbar2000

Member

From: Brazil

Registered: 2016-10-26

Posts: 108

How get Errors on EngineDelete?????

function TRestStorageExternal.ExecuteDirect(const SqlFormat: RawUtf8;
  const Args, Params: array of const; ExpectResults: boolean): ISqlDBRows;
var
  stmt: ISqlDBStatement;
begin
...
  try
    stmt := fProperties.NewThreadSafeStatementPrepared(
      SqlFormat, Args, ExpectResults, {except=}true);   <<<< when some exception happens here....
...
  except
    <<<<<<<<<<<< FLastDBErro dont is filled
    stmt := nil;
    HandleClearPoolOnConnectionIssue; // leave result=nil to notify error
  end;
end;

then if i try get erro with GetDbError i receive a empty string.

my sugestion

  except
    on E: Exception do
    begin
      SetDbError(E.Message);
      stmt := nil;
      HandleClearPoolOnConnectionIssue; // leave result=nil to notify error
    end;
  end;

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,934

Website

Re: How get Errors on EngineDelete?????

My guess is that it is a problem at the DB provider level, not at ORM level.
In fact, the ECoreDBException.CreateAfterSetMessageUtf8 method should be called by the exception class itself, when it occurs.
It is too late to try to fix it at ORM level.

What is the exception class?
Which SQL DB layer are you using?

I have tried to fix it for all DB units.
Please check with
https://github.com/synopse/mORMot2/commit/6030847b7