mORMot Open Source

WLemmy

Member

Registered: Yesterday

Posts: 2

Bug in mormot.db-sql.ibx.pas

Hello,

I try mormot.db.sql.ibx.pas and I think I found a bug:

in procedure TSqlDBIbxStatement.ColumnToJson(Col: integer; W: TJsonWriter);

current code:

      SQL_BLOB:
        begin
          if ForceBlobAsNull then
            W.AddNull
          else
          begin

but this works:

      SQL_BLOB:
        begin
          if dsfForceBlobAsNull in fFlags then 
            W.AddNull
          else
          begin

Can someone confirm my change and maybe change the repository?

Best regards

Last edited by WLemmy (Yesterday 17:31:49)

ttomas

Member

Registered: 2013-03-08

Posts: 165

Re: Bug in mormot.db-sql.ibx.pas

Yes it is correct fix, I will prepare pull request

ttomas

Member

Registered: 2013-03-08

Posts: 165

Re: Bug in mormot.db-sql.ibx.pas

Pull request fix blob and datetime types. Also fix small memory leak of IBX cached interface.
https://github.com/synopse/mORMot2/pull/488

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 15,513

Website

Re: Bug in mormot.db-sql.ibx.pas

Was merged ASAP.

WLemmy

Member

Registered: Yesterday

Posts: 2

Re: Bug in mormot.db-sql.ibx.pas

Thank you very much!