Problem with Currency properties

WladiD · 2011-04-18 16:11:57

Hi Arnaud,

today I noticed, that published Currency properties of TSQLRecord descendants aren't serialized properly in TSQLRecord.GetJSONValues:

procedure TSQLRecord.GetJSONValues(W: TJSONWriter);
begin
...
  sftCurrency:
    W.AddCurr64(Fields[i]^.GetInt64Value(self)); // NOTE: Take a look at GetInt64Value...
...
end;

function TPropInfo.GetInt64Value(Instance: TObject): Int64;
begin
  if (Instance<>nil) and (@self<>nil) then

  // NOTE: The Kind of a Currency is tkFloat but here is no handling for it!

  case PropType^^.Kind of
    tkInteger,tkEnumeration,tkSet,{$ifdef FPC}tkBool,{$endif}tkClass:
      result := GetOrdProp(Instance,pointer(@self));
    tkInt64:
      result := GetInt64Prop(Instance,pointer(@self));
    else result := 0;
  end else
    result := 0;
end;

with my quick fix it works well again:

procedure TSQLRecord.GetJSONValues(W: TJSONWriter);
begin
...
  sftCurrency:
    W.AddCurr64(GetInt64Prop(self, Fields[i]));
...
end;

If you need more info, lets me know and I try to create a small test case...

Best regards!

ab · 2011-04-18 17:35:40

I made a code review around similar possible issues, and fixed some potential breaks.
See http://synopse.info/fossil/info/effdec39f4

Nice catch! Thanks!

WladiD · 2011-04-18 19:40:09

Thank you for the fast bug fix!

I'm looking forward to the new 1.13

P.S.: I sent (for a couple weeks) a personal message through this forum. Did you received it?

coblongpamor · 2011-06-13 12:45:23

hi..
I Created new form inherited from TRecordEditForm (part of the framework),
but with Currency Field Type, i can only type just one digit numerical value, but i can type "00000"...

what is the problem?

note:
i use the MainDemo from the framework..

ab · 2011-06-14 11:23:28

There may be an issue in the SQLite3UIEdit.pas.
At first, I don't see any problem: the currency type is handled properly (field value is set as currency, then retrieve from an extended conversion).
Perhaps the TSynLabeledEdit defined in SQLite3UI.pas has some problems with a currency value.

I'll check this, but I need to write a simple program to reproduce it first.
Or perhaps you've one at hand?

coblongpamor · 2011-06-14 12:18:20

I try to trace the code of TSynLabeldEdit.
i think the problem is on MaxValue property, there set to 100 on constructor.

but i don't know how to set it dinamically depending on Kind:TSynLabeledEditKind property.

ab · 2011-06-14 14:34:55

Setting the MaxValue to 100 is a bug, I think.

There should be no maximum value by default, only if a corresponding validation rule is set for this field.

coblongpamor · 2011-06-14 16:33:53

so, what sould to be corection? because it checked on the keypress event.

if IsValid(TempString,Temp) and (Temp>MaxValue) then begin
    Key := #0;
    Beep;
  end;

ab · 2011-06-15 06:01:28

Check this out:
http://synopse.info/fossil/info/6f2a76894f

There was some dubious code in several units.

coblongpamor · 2011-06-15 09:25:26

thanks for the quick fix..

ab · 2011-06-15 12:00:45

See http://synopse.info/forum/viewtopic.php?id=345 for a compilation issue.

coblongpamor · 2013-02-04 14:34:12

TSynLabeledEdit.IsValid doesn't work for me with sleCurrency Kind.

...
    sleCurrency: begin
      val(Txt,resDouble,err);
      if err<>0 then exit;
//      ToValue := Currency(resDouble); //this is not work as expected
      ToValue := FloatToCurr(resDouble); // i try this, and so far, its work
    end;
...

ab · 2013-02-04 15:23:49

Is this working?

var tmpCurr: currency;
...
    sleCurrency: begin
      val(Txt,resDouble,err);
      if err<>0 then exit;
      tmpCur := resDouble;
      ToValue := tmpCur;

coblongpamor · 2013-02-04 15:43:00

yes, it's working great. thanks.

ab · 2013-02-04 15:53:42

Fixed by http://synopse.info/fossil/info/58715d90b8

Thanks for the report.

coblongpamor · 2013-02-05 07:19:30

thank you.
BTW, what is the shortage when i use FloatToCurr(resDouble)?

ab · 2013-02-05 08:00:09

FloatToCurr() just check the input value range, then assign it to currency.

Our fix consists in using an explicit temporary currency variable, then assign this currency variable to the variant.
Most of the time, currency(resDouble) does the conversion, but it appears that when assigning to a variant, an explicit temporary currency variable is needed.
Weird code generation, I guess, from the compiler point of view.

coblongpamor · 2013-02-05 08:43:08

ok. thank you for explanation.

mORMot Open Source

#1 2011-04-18 16:11:57

Problem with Currency properties

#2 2011-04-18 17:35:40

Re: Problem with Currency properties

#3 2011-04-18 19:40:09

Re: Problem with Currency properties

#4 2011-06-13 12:45:23

Re: Problem with Currency properties

#5 2011-06-14 11:23:28

Re: Problem with Currency properties

#6 2011-06-14 12:18:20

Re: Problem with Currency properties

#7 2011-06-14 14:34:55

Re: Problem with Currency properties

#8 2011-06-14 16:33:53

Re: Problem with Currency properties

#9 2011-06-15 06:01:28

Re: Problem with Currency properties

#10 2011-06-15 09:25:26

Re: Problem with Currency properties

#11 2011-06-15 12:00:45

Re: Problem with Currency properties

#12 2013-02-04 14:34:12

Re: Problem with Currency properties

#13 2013-02-04 15:23:49

Re: Problem with Currency properties

#14 2013-02-04 15:43:00

Re: Problem with Currency properties

#15 2013-02-04 15:53:42

Re: Problem with Currency properties

#16 2013-02-05 07:19:30

Re: Problem with Currency properties

#17 2013-02-05 08:00:09

Re: Problem with Currency properties

#18 2013-02-05 08:43:08

Re: Problem with Currency properties

Board footer