mORMot Open Source

Its easy to check if this is a db or code issue, just run the query directly on your preferred db tool and see how long it runs without any code or services involved.  My guess is that you should be able to reduce the query runtime by correctly indexing the tables. 

I've seen how correct indexes can dramatically reduce query times, but also the reverse.  Adding and combining indexes that are not used will increase insert times, and increase the chances of the db engine using the wrong indexes - slowing down search times.

ab's suggestion of aggregation is very valuable and makes a big difference.  It is something you should seriously consider.  Grouping data in separate summary/reporting tables and populating/updating them at fixed intervals provides a lot of stability and speed.  It means only a small number of records are queried by reports, and also that running those reports does not impact the real datatables that are used by operations.

Thanks @ab.  I’ve done the whole lock/unlock thing everytime any of my code touches the IList, which obviously leads directly to copy/paste issues, and unreadable code.  I guess the only sensible way of using it then would be if I define a class which has the ilist as a property and custom add/delete/count/index/pop functions that lock/unlock as needed.

Ok, this makes a lot of sense, and it looks like this is what is done in the restws_chatserver sample project

But this is where I start to feel like a preschool child learning the alphabet:

From the sample project, it looks as if the interfaces has to be defined twice.  One that does the work and always contain a callback parameter in all the functions, and one that is used to send the response to the request.  When a response needs to be sent, the working function needs to step through all the connections manually, find the appropriate one and trigger the callback, then delete it from the list of callbacks?  Since there is no implementation of the callback interface's functions, I guess only one standard one needs to be defined?

Thanks, not sure yet how to fit that workflow in with a javascript client, but will try.

Thanks @ab.  Then it may be a good idea for me to wait a few days.

Thank you so much for this @ab!

Besides being very very useful, it also makes the code more readable and understandable, especially when someone unfamiliar with mORMot needs to work on/review our code. 

High-level wrappers like these makes it possible for the power of mORMot to be fully used without needing to know the technical details of everything that is possible, but undiscoverable in this great framework.

If there is a way to get OnBeforeURI to be triggered in this scenario, then I can do a redirect or handle it in many ways.

Thanks to @htits2008 for pointing me in the right direction.  For anybody else affected by the same issue, here is a procedure to fix it.  Just remember to add all new methods where you call it, otherwise they will still be affected by it.  Maybe there is a way to get a list of all the method based functions (not the interface functions) and step through them at create time so that this procedure can be called without parameters?  Will check later when more time is available:

procedure FixURIRoutingMess(const HttpServer: TRestHttpServer; const methods: array of string);
var
  I, R: Integer;
  J: TUriRouterMethod;
  tmpURI: string;
begin
  for I := 0 to Length(methods) -1 do
    for R := 0 to HttpServer.RestServerCount -1 do
    begin
      tmpURI := '/' + HttpServer.RestServer[R].Model.Root + '/' + methods[I];
      for J := urmGet to urmHead do
        HttpServer.Route.Rewrite(J, tmpURI + '/', J, tmpURI);
    end;
end;

This can be called something like this (based on the pastee sample above):

  FixURIRoutingMess(aHttpsServer, ['method1']);

Is there any way to get OnBeforeURI to trigger in this scenario in mORMot 2 like it does in 1?

I'm using Delphi 10.3.

example-03:
in u_SharedTypes, the following line causes [dcc32 Error] u_SharedTypes.pas(75): E2034 Too many actual parameters
      pmCheckedFileName^ := TPath.Combine(dirName, fileName, False)
Removing the ,false parameter will cause it to compile.

I hope there is a way to restore the mORMot1 uri parsing that allows the trailing /, since I am porting projects to mORMot 2 that depends on it being consistent.

Increasing the thread pool size is the quick solution, yes.  But that misses the point.  The point I was trying to make, is that there are different uses for rest calls on the same system.  Some are quick and high priority, such as logging in and editing records.  It is reasonable to expect them to complete in a few ms, and not consume 32 threads.  However, there are other types of functionality that takes longer, but are lower priority, such as running complicated reports. 

The idea is to be able to put "slow" type tasks in their own queue and not allow them to bring the whole rest server to a halt.  If the thread pool size is simply increased to 32, then running 32 slow reports (or 1 slow report being used by 40 users) will effectively prevent other users from completing higher priority tasks such as logging in and editing records until those slow tasks have been completed. 

If there is a functionality to create "tasks" for those requests, they can be placed in a queue or something to manage them, releasing them from the rest server's thread pool until they complete and perform a callback to instruct the rest server to complete the request.

Has anybody had any success implimenting this oauth2.0 into their project?

Thanks @ab.  I'll take a look.

Re the parameter binding, is this what you are referring to? https://dev.mysql.com/doc/c-api/5.6/en/ … param.html

Will the InitArrayFrom still provide the same structure / result when it is not an array?  I thought that would only apply to dynamic array types.

Thanks TOrmTableWritable works perfectly.  I've been using windows grep for most of the day searching for the replacements.  Not sure how I missed this one.  Looks like my list is now starting to become useful.  I should be able to start migrating as soon as I find out about TDocVariantData.InitFromTypeInfo

Does anybody still have copies of these gists available? I need a mormot server with oauth authentication and was hoping this would be something to build on.  But the gists seem to be all gone already.

Yes, that is probably it.  Maybe its a browser issue.  I wont worry too much about that now.

I have done something similar to the documentation, but it looks as if all requests are then executed sequentially.  I created a method that executes the functions like this

  if Services['Calculator'].Get(svr) then
    if SameText(req.FunctionName, 'Add') then
      Ctxt.Returns(svr.Add(1, 2))

To come to that conclusion, I did something like this in Add:

...
  StartTime := now;
  Sleep(5000);
  StopTime := now;
  Result := '{"function": "Add", "StartTime": "' + DateTimeToStr(StartTime) + '", "StopTime": "' + DateTimeToStr(StopTime) + '"}';
..

When I open 2 browsers and call the above method at almost the same time, the results indicate that they are executed one after the other:

browser1: {"function": "Add", "StartTime": "2022/05/12 11:26:56", "StopTime": "2022/05/12 11:27:01"}
browser2: {"function": "Add", "StartTime": "2022/05/12 11:27:01", "StopTime": "2022/05/12 11:27:06"}

Is this the expected behaviour, or am I doing something wrong?  The interface was declared with sicShared, but the same effect is seen when using sicPerThread or sicSingle .

How would I then find and execute the correct function on that interface with the correct parameters?  I assume I'll have to search for the methodindex from the interfacefactory and then step through and assign the declared parameters?
Have someone done something like this before?

Since ExecuteCommand is private, how would the function be called after the parameters are assigned?

TSQLRestServerFullMemory