mORMot Open Source

mpv

Member

From: Ukraine

Registered: 2012-03-24

Posts: 1,571

Website

SynUnicode in FPC is WideString. Is it OK?

@AB, may be we should change a SynUnicode definition a little.
From:

{$ifdef UNICODE}
  SynUnicode = UnicodeString;
{$else}
  SynUnicode = WideString;
{$endif}  

To:

{$ifdef UNICODE}
  SynUnicode = UnicodeString;
{$else}
  {$ifdef FPC}
    SynUnicode = UnicodeString;
  {$else}
    SynUnicode = WideString;
  {$endif}
{$endif}  

As far as I understand it does not matter for Linux except (IMHO) is become more clear.
But for FPC on Windows should be better. Isn't it?

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 14,649

Website

Re: SynUnicode in FPC is WideString. Is it OK?

I am afraid it may fail in some other places, which expect SynUnicode=UnicodeString only with UNICODE conditional.