[FEATURE] System.Generics.Collections implementation on SynCrossPlatf

turrican · 2017-08-29 08:53:06

Hi,

To improve the compatibility with original mORMot, it would be great to implement generics.

For example :

    function RetrieveList(Table: TSQLRecordClass; const FieldNames,
      SQLWhere: string; const BoundsSQLWhere: array of const): TObjectList;

For this :

{$IFDEF NEXTGEN}
    function RetrieveList(Table: TSQLRecordClass; const FieldNames,
      SQLWhere: string; const BoundsSQLWhere: array of const): TObjectList<T>;
{$ELSE}
    function RetrieveList(Table: TSQLRecordClass; const FieldNames,
      SQLWhere: string; const BoundsSQLWhere: array of const): TObjectList;
{$ENDIF}

ab · 2017-08-29 09:02:30

I would rather add something like in the main mORMot.pas unit.

That is, properly using generics for the overloaded version - something like:

    {$ifdef ISDELPHI2010} // Delphi 2009 generics support is buggy :(
    function RetrieveList<T: TSQLRecord>(const FieldNames, SQLWhere: string; const BoundsSQLWhere: array of const): TObjectList<T>; overload;
       {$ifdef HASINLINE}inline;{$endif}
    {$endif}

Your version would be confusing for the compiler.

turrican · 2017-08-29 09:13:23

ab wrote:

I would rather add something like in the main mORMot.pas unit.
That is, properly using generics for the overloaded version - something like:
    {$ifdef ISDELPHI2010} // Delphi 2009 generics support is buggy :(
    function RetrieveList<T: TSQLRecord>(const FieldNames, SQLWhere: string; const BoundsSQLWhere: array of const): TObjectList<T>; overload;
       {$ifdef HASINLINE}inline;{$endif}
    {$endif}
Your version would be confusing for the compiler.

Yes it's much better than mine.

ab · 2017-08-29 13:07:36

I've added TSQLRest.RetrieveList<T> to the cross-platform clients.
See https://synopse.info/fossil/info/1bbe25b1c6

turrican · 2017-08-30 07:05:24

ab wrote:

I've added TSQLRest.RetrieveList<T> to the cross-platform clients.
See https://synopse.info/fossil/info/1bbe25b1c6

Great! Thank you very much!

ab · 2017-08-30 08:25:40

Feedback is welcome: I didn't test it on NextGen/iOS/Android platforms.

turrican · 2017-08-30 09:55:26

ab wrote:

Feedback is welcome: I didn't test it on NextGen/iOS/Android platforms.

I'm currently developing/testing it for a Firemonkey Android client. I will back with updates.

mORMot Open Source

#1 2017-08-29 08:53:06

[FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#2 2017-08-29 09:02:30

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#3 2017-08-29 09:13:23

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#4 2017-08-29 13:07:36

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#5 2017-08-30 07:05:24

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#6 2017-08-30 08:25:40

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

#7 2017-08-30 09:55:26

Re: [FEATURE] System.Generics.Collections implementation on SynCrossPlatf

Board footer