Pull requests #303, #304

Eugene Ilyin · 2020-04-10 18:50:34

Hi ab,

Just couple of lines with minor amendmends (remove some compiler warnings in stubs, one additional constant):

Pull request #303

  HTTP_PARAMETER_REQUIRED = 402;

Pull request #304

function TOpenSSLConnectionClient.Connect(...): boolean;
begin
  result := false;
end;

function TOpenSSLConnectionClient.SecureWrite(...): boolean;
begin
  result := false;
end;

ab · 2020-04-11 10:17:19

Merged!

Thanks for sharing!

Eugene Ilyin · 2020-04-11 16:56:43

Thanks, ab.

Eugene Ilyin · 2020-04-11 17:41:41

Hi sakura,

Seems like HTTP 402 is reserved as per RFC 7231:

6.5.2. 402 Payment Required
The 402 (Payment Required) status code is reserved for future use.

And in real practice this HTTP code has very unclear semantic:

402 Payment Required
Reserved for future use. The original intention was that this code might be used as part of some form of digital cash or micropayment scheme, as proposed, for example, by GNU Taler, but that has not yet happened, and this code is not widely used. Google Developers API uses this status if a particular developer has exceeded the daily limit on requests. Sipgate uses this code if an account does not have sufficient funds to start a call. Shopify uses this code when the store has not paid their fees and is temporarily disabled. Stripe uses this code for failed payments where parameters were correct, for example blocked fraudulent payments.

May be it will be better to revert #303, what do you think?

Last edited by Eugene Ilyin (2020-04-12 18:20:14)

sakura · 2020-04-12 18:00:11

Eugene Ilyin wrote:

Hi sakura,
Seems like HTTP 402 is reserved as per FRC 7231:
6.5.2. 402 Payment Required
The 402 (Payment Required) status code is reserved for future use.

Interesting, I had found another definition before, just can't find it again :-( But I guess, that's the better one.

mORMot Open Source

#1 2020-04-10 18:50:34