Rename Asynch to Async (unit name and classes)

zed · 2021-02-03 06:38:48

The word "Asynchronous" is usually abbreviated as async, not asynch: https://i.imgur.com/i4MiMIn.png

https://github.com/synopse/mORMot2/blob … asynch.pas

sakura · 2021-02-03 06:58:39

I would leave it at asynch - while you are right - async may just become a keyword at some point, as it is in other languages already, and thus may break compiling, when used in/as unit names ;-)

ab · 2021-02-03 13:43:10

The keyword argument is a good one, even if I didn't suspect it.

macfly · 2021-02-03 14:00:36

Google suggests the most used term.

But i think that both are correct.

In description itself mentions "out of synch".

ab · 2021-02-03 14:26:03

Since we don't use "Asynch" as a stand-alone word, it won't break as a potential keyword...

I have therefore renamed every Asynch into Async everywhere, including the mormot.net.async.pas unit and all types.
Check https://github.com/synopse/mORMot2/comm … fc18c48364

sakura · 2021-02-04 10:00:07

ab wrote:

Since we don't use "Asynch" as a stand-alone word, it won't break as a potential keyword...

In Delphi it might break, a unit name like mORMot.Core.Const would not work.

Just sayin' ;-)

mpv · 2021-02-04 21:12:38

I don't think async/await conception (at last in form of keywords) comes to Pascal world in the nearest 20 years, so nothing to warry about

mORMot Open Source

#1 2021-02-03 06:38:48

Rename Asynch to Async (unit name and classes)

#2 2021-02-03 06:58:39

Re: Rename Asynch to Async (unit name and classes)

#3 2021-02-03 13:43:10

Re: Rename Asynch to Async (unit name and classes)

#4 2021-02-03 14:00:36

Re: Rename Asynch to Async (unit name and classes)

#5 2021-02-03 14:26:03

Re: Rename Asynch to Async (unit name and classes)

#6 2021-02-04 10:00:07

Re: Rename Asynch to Async (unit name and classes)

#7 2021-02-04 21:12:38

Re: Rename Asynch to Async (unit name and classes)

Board footer